Add scoped token generation to github_app_token data source#3101
Open
elliotwms wants to merge 4 commits intointegrations:mainfrom
Open
Add scoped token generation to github_app_token data source#3101elliotwms wants to merge 4 commits intointegrations:mainfrom
elliotwms wants to merge 4 commits intointegrations:mainfrom
Conversation
Allow scoping installation access tokens to specific repositories by passing the optional repositories parameter to the GitHub API. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
stevehipwell
requested changes
Jan 20, 2026
Collaborator
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @elliotwms, I've added a couple of review comments.
|
|
||
| variable "repositories" { | ||
| type = list(string) | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
Please make sure all your files have valid line endings.
Comment on lines
+59
to
+64
| var repositories []string | ||
| if v, ok := d.GetOk("repositories"); ok { | ||
| for _, repo := range v.([]any) { | ||
| repositories = append(repositories, repo.(string)) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| var repositories []string | |
| if v, ok := d.GetOk("repositories"); ok { | |
| for _, repo := range v.([]any) { | |
| repositories = append(repositories, repo.(string)) | |
| } | |
| } | |
| var repos []string | |
| if v, ok := d.GetOk("repositories"); ok { | |
| if a, ok := v.([]any); ok { | |
| repos := make([]string, len(a)) | |
| for i, r := range a { | |
| if repo, ok := r.(string); ok { | |
| repos[i] = repo | |
| } | |
| } | |
| } | |
| } |
This would be a safer pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3102
Before the change?
repositoriesargument to thegithub_app_tokendata sourceAfter the change?
repositoriesargument to thegithub_app_tokendata sourceProof of work
Tested using
examples/github_app_token:Pull request checklist
Schema migrations have been created if needed (example)Does this introduce a breaking change?
Please see our docs on breaking changes to help!