Add Delphi 10.2 Tokyo support via dedicated client and tool frame #101

andrevfarias · 2025-11-04T13:51:05Z

This PR introduces initial compatibility for Delphi 10.2 Tokyo by adding a dedicated client build and a Tokyo-specific tool window implementation. It addresses the request to support older Delphi IDEs, motivated by issue #14.

Summary of changes

New Tokyo tool frame:
- Added DelphiLint.ToolFrame.Tokyo.pas/.dfm, using TListView and TWebBrowser (SHDocVw) instead of newer components that are not available on 10.2.
New 10.2 Tokyo client projects:
- Added client/source/DelphiLintClient250.dpk, DelphiLintClient250.dproj, and group project client/DelphiLintClientProjects250.groupproj.
- Added test project client/test/DelphiLintClientTest250.dpr/.dproj.
Conditional compilation for older IDEs:
- DelphiLint.Plugin.pas selects DelphiLint.ToolFrame.Tokyo when CompilerVersion < 33.0.
- DelphiLint.IDEContext.pas uses IOTAIDEThemingServices250 where required.
Build and packaging:
- scripts/build.ps1 updated to support version 250 (Tokyo), map registry version 19.0, and use DCC_UseMSBuildExternally=true to avoid long command-line issues.
Minor compatibility tweaks across units (Analyzer, HtmlGen, Server, Settings, etc.) to compile and run on Tokyo.
No behavior changes for Alexandria/Athens; newer IDEs continue using the existing frame and WebView2.

Why

Many teams still use Delphi 10.2 Tokyo, and the main client relies on components not available there. This PR provides a safe, isolated implementation for Tokyo without impacting newer Delphi versions. See issue #14.

Build notes

Use the existing build pipeline with the 250 target (e.g., build.ps1 250).

Impact

Adds 10.2 support with a separate UI implementation; maintains current behavior for Delphi 11/12.

fourls

Hi @andrevfarias, thank you for the PR! It mostly looks good and I'm happy to accept most of its changes to improve compatibility with older Delphi versions.

I have made some comments. Because I do not have Tokyo installed, I will not be able to test it or ensure any quality guarantees.

Many teams still use Delphi 10.2 Tokyo, and the main client relies on components not available there.

I'm not super comfortable with how specific this change is to 10.2. Many teams still use Delphi 7, XE3, etc, but that doesn't seem like a reason to require a separate tool frame for each of those versions as well. Could we reframe this as a more general "legacy tool frame" instead of something specific to a minor release of the compiler?

Also, the build script should not be updated to build unsupported versions of Delphi. The purpose of the build script is for packaging and release, which won't need to be done for unsupported versions. There's also nothing special about 10.2 that necessitates it being added to the build script, and it implies a guarantee that it will be compatible (which there is not).

The script doesn't do anything fancy, so if you'd like to compile an unsupported version's BPL it can just be compiled in the IDE / via MSBuild / whatever approach is best for your setup. Or by making the changes to the build script locally.

fourls · 2025-11-07T01:29:48Z

client/source/DelphiLint.FileLogger.pas


  if not TFile.Exists(FLogPath) then begin
-    FreeAndNil(TFile.Create(FLogPath));
+    TFile.Create(FLogPath).Free;


What's the purpose of these changes?

fourls · 2025-11-07T01:29:55Z

client/source/DelphiLint.Handlers.pas

+    Hook.Free;
  end;
-  FreeAndNil(FPopupHooks);
+  FreeAndNil(FPopupHooks); // Remover?


What does this comment mean?

fourls · 2025-11-07T01:32:21Z

client/source/DelphiLint.HtmlGen.pas


 function TRuleHtmlGenerator.BuildHtmlPage(BodyHtml: string; BodyClass: string): string;
+
+  function GetLegacyScript: string;


Webpack/Babel can polyfill for old IE versions (see client/jslib/webpack.config.js) so there's no need to include it ourselves. Could you identify the IE version you want to support and try configuring webpack to bundle for that version?

fourls · 2025-11-07T01:33:46Z

client/source/DelphiLint.IDEContext.pas

+{$IF CompilerVersion < 33.0}
+  (BorlandIDEServices as IOTAIDEThemingServices250).RegisterFormClass(FormClass);
+{$ELSE}
  (BorlandIDEServices as IOTAIDEThemingServices).RegisterFormClass(FormClass);
+{$ENDIF}


There's no need to do the ifdef here, just change to 250 if it's a compatibility issue. Newer Delphi versions also have the 250 version.

fourls · 2025-11-07T01:36:04Z

client/source/DelphiLint.OptionsForm.pas

 begin
  LintContext.IDEServices.ApplyTheme(Self);
-  WindowColor := StyleServices(Self).GetSystemColor(clWindow);
+  WindowColor := StyleServices.GetSystemColor(clWindow);  


Please remove this trailing whitespace.

fourls · 2025-11-07T01:38:25Z

client/source/DelphiLint.SetupForm.pas

 begin
  LintContext.IDEServices.ApplyTheme(Self);
-  WindowColor := StyleServices(Self).GetSystemColor(clWindow);
+  WindowColor := StyleServices.GetSystemColor(clWindow);  


Please remove this trailing whitespace.

fourls · 2025-11-07T01:40:44Z

client/source/DelphiLint.ToolFrame.Tokyo.pas

Please

Translate comments to English

Remove Tokyo-specific references

Include this unit in all DelphiLintClient dprojs

fourls · 2025-11-07T01:43:23Z

scripts/build.ps1

Please revert this change. As stated previously, we will not be officially supporting building for versions of Delphi before Delphi 11, especially not specifically for 10.2.

fourls · 2025-11-07T01:43:34Z

scripts/TEMPLATE_install.ps1

What's the purpose of this change?

fourls · 2025-11-07T01:44:17Z

...philint-server/src/main/java/au/com/integradev/delphilint/analysis/AnalysisOrchestrator.java

+    if (properties.containsKey("sonar.sourceEncoding")) {
+      return Charset.forName(properties.get("sonar.sourceEncoding"));
+    } else if (properties.containsKey("sonar.encoding")) {


Oops, this seems like a legitimate bug, thanks for picking this up. Could you move this out into a separate commit?

andrevfarias added 2 commits November 4, 2025 10:27

refactor: add language compatibity for legacy delphi version compilers

fcd3e79

feat: Add Delphi project for Tokyo compatibility

03873b8

andrevfarias mentioned this pull request Nov 4, 2025

Add old Delphi support if possible #14

Closed

2 tasks

fourls requested changes Nov 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Delphi 10.2 Tokyo support via dedicated client and tool frame #101

Add Delphi 10.2 Tokyo support via dedicated client and tool frame #101

Uh oh!

andrevfarias commented Nov 4, 2025

Uh oh!

fourls left a comment

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

fourls Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		function TRuleHtmlGenerator.BuildHtmlPage(BodyHtml: string; BodyClass: string): string;

		function GetLegacyScript: string;

Add Delphi 10.2 Tokyo support via dedicated client and tool frame #101

Are you sure you want to change the base?

Add Delphi 10.2 Tokyo support via dedicated client and tool frame #101

Uh oh!

Conversation

andrevfarias commented Nov 4, 2025

Uh oh!

fourls left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants