Skip to content

fix: correctly detect old-style MOV files (no ftyp box)#43

Merged
bajankristof merged 2 commits intomainfrom
fix/mov
Apr 1, 2026
Merged

fix: correctly detect old-style MOV files (no ftyp box)#43
bajankristof merged 2 commits intomainfrom
fix/mov

Conversation

@bajankristof
Copy link
Copy Markdown
Collaborator

No description provided.

@bajankristof bajankristof requested a review from Copilot April 1, 2026 10:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates FFMPEG::Media#extname to better handle QuickTime/MOV files where ffprobe can’t determine a major_brand (e.g., old-style MOVs without an ftyp box), and ships the fix as a patch release.

Changes:

  • Treat major_brand == nil as a QuickTime MOV for mov|mp4 demuxed formats.
  • Add an RSpec example for the “old-style MOV without ftyp” scenario (via stubbing).
  • Bump gem version to 8.4.2 and document the fix in the changelog.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
lib/ffmpeg/media.rb Adjusts extname MOV/MP4 branching to return .mov when major_brand is nil.
spec/ffmpeg/media_spec.rb Adds a spec asserting .mov when major_brand is nil for a MOV fixture.
lib/ffmpeg/version.rb Version bump to 8.4.2.
CHANGELOG Adds release notes for 8.4.2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bajankristof bajankristof merged commit afaf5a4 into main Apr 1, 2026
17 checks passed
@bajankristof bajankristof deleted the fix/mov branch April 1, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants