Skip to content

fix: detect more file extensions correctly #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajankristof merged 2 commits into from
Apr 1, 2026
+10 −2
Merged

fix: detect more file extensions correctly #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0f90d9
fix: detect more file extensions correctly
bajankristof Apr 1, 2026
3f08c0c
chore: update version to 8.4.1 and document changes
bajankristof Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
== 8.4.1 2026-04-01

Fixes:
* Correctly detect the file extension for `asf_o`, `live_flv`, `mpegvideo` and `mpegtsraw` formats.

== 8.4.0 2026-03-20

Improvements:
Expand Down
5 changes: 4 additions & 1 deletion lib/ffmpeg/media.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ def initialize(message, output)
case format_name
when /\Adash\b/ then '.mpd'
when /\bhls\b/ then '.m3u8'
when /\bmpegts\b/ then '.ts'
when /\bmpegts(raw)?\b/ then '.ts'
when /\bmpegvideo\b/ then '.mpg'
when /\blive_flv\b/ then '.flv'
when /\basf_o\b/ then '.asf'
Copy link
Copy Markdown

@ZoltanDalmadi ZoltanDalmadi Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is also .3gp which might be worth to add here

Copy link
Copy Markdown
Collaborator Author

@bajankristof bajankristof Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that will already be handled by the else branch

when /\b(mov|mp4)\b/
case major_brand
when /\Aqt\b/i then '.mov'
Expand Down
2 changes: 1 addition & 1 deletion lib/ffmpeg/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module FFMPEG
VERSION = '8.4.0'
VERSION = '8.4.1'
end
Loading