Open
Conversation
typesScript-eslint and vitest/eslint-plugin also needed to be updated. All changes are to fix breaking code in the new TS
… lucide-react for new icons
…aller dependency updates
matyasf
commented
Apr 2, 2026
| // Alternatively you can use CommonJS syntax: | ||
| // require('./commands') | ||
|
|
||
| import { mount } from 'cypress/react18' |
Collaborator
Author
There was a problem hiding this comment.
changed syntax in Cypress 14 https://docs.cypress.io/app/references/changelog#14-0-0
matyasf
commented
Apr 2, 2026
| // This needs to be required, otherwise TSC will mess up the directory structure | ||
| // in the output directory | ||
| // eslint-disable-next-line @instructure/no-relative-imports | ||
| const rootPackage = require('../../../package.json') // root package.json |
Collaborator
Author
There was a problem hiding this comment.
in TS 6 one must configure the rootDir, and this file was outside of it. I simply point to the docs app's package.json now and hardcode the name parameter (this whole thing is a remnant when this was meant as an universal app)
|
matyasf
commented
Apr 2, 2026
| * SOFTWARE. | ||
| */ | ||
| import React from 'react' | ||
| declare const process: Record<string, any> | undefined |
Collaborator
Author
There was a problem hiding this comment.
In TS 6 this must be explicitly declared otherwise it will throw an error for web builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update TS to version 6; also update lots of smaller dependencies.
To test: