Fix docs showing theme variables from 11.7 for 11.6 docs#2491
Open
Fix docs showing theme variables from 11.7 for 11.6 docs#2491
Conversation
Docs was showing the new, rewritten Canvas and Canvas high contrast theme variables in the v11_6 pages. This fix makes it show the correct version. To test: Check the theme variables and compare it with the new theme changelog. e.g. Mask should show different values in 11.6 and 11.7 docs. fixes INSTUI-4977
matyasf
changed the title
|
matyasf
commented
Mar 27, 2026
| componentVersion?: string | ||
| } | ||
|
|
||
| export const AppContext = createContext<AppContextType>({ |
Collaborator
Author
There was a problem hiding this comment.
This needed to be extracted otherwise React would throw a circular dependency error
matyasf
commented
Mar 27, 2026
Comment on lines
+91
to
+93
| const isLegacyTheme = this.context?.componentVersion == 'v11_6' | ||
| // new theme | ||
| if (!isLegacyTheme) { |
Collaborator
Author
There was a problem hiding this comment.
This is the actual fix. Previously we were always showing the new theme if it was avaialbe. Now we show the old theme if we're showing v11.6 components
balzss
approved these changes
Mar 31, 2026
| class App extends Component<AppProps, AppState> { | ||
| static allowedProps = allowedProps | ||
| static contextType = AppContext | ||
| declare context: React.ContextType<typeof AppContext> |
Contributor
There was a problem hiding this comment.
nitpick, no need to change it but I'd just import ContextType instead of React. Imports are treeshaken so it doesn't actually matter
git-nandor
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs was showing the new, rewritten Canvas and Canvas high contrast theme variables in the v11_6 pages. This fix makes it show the correct version.
To test:
Check the theme variables and compare it with the new theme changelog. e.g. Mask should show different values in 11.6 and 11.7 docs.
fixes INSTUI-4977