Skip to content

feat(ui-byline): rework Byline#2479

Merged
git-nandor merged 1 commit intomasterfrom
Byline_rework
Apr 1, 2026
Merged

feat(ui-byline): rework Byline#2479
git-nandor merged 1 commit intomasterfrom
Byline_rework

Conversation

@git-nandor
Copy link
Copy Markdown
Contributor

INSTUI-4966

Rework Byline

Test:
Check doc Byline page.

@git-nandor git-nandor self-assigned this Mar 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-01 14:09 UTC

@git-nandor git-nandor force-pushed the Byline_rework branch 2 times, most recently from cc5dbda to df9f4df Compare March 19, 2026 17:37
@git-nandor git-nandor marked this pull request as ready for review March 26, 2026 14:51
Copy link
Copy Markdown
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@git-nandor git-nandor requested a review from adamlobler March 31, 2026 13:00
@ToMESSKa
Copy link
Copy Markdown
Contributor

ToMESSKa commented Apr 1, 2026

@git-nandor I think commit should include that this a breaking change too because of the theming engine

Copy link
Copy Markdown
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Byline is a component that can be used on any kind of surface. Right now, it has a background color that might differ from the surface it’s placed on. I would remove this background color to prevent these weird edge cases.

Image

Can we do that @matyasf ?

@balzss
Copy link
Copy Markdown
Contributor

balzss commented Apr 1, 2026

Byline is a component that can be used on any kind of surface. Right now, it has a background color that might differ from the surface it’s placed on. I would remove this background color to prevent these weird edge cases.

Image Can we do that @matyasf ?

@adamlobler as per our conversation we agreed to change the bg token value in the new light and dark themes to transparent. this PR will stay open until the token change to double check the result. let us know when that's done

@adamlobler
Copy link
Copy Markdown
Collaborator

Byline is a component that can be used on any kind of surface. Right now, it has a background color that might differ from the surface it’s placed on. I would remove this background color to prevent these weird edge cases.
Image
Can we do that @matyasf ?

@adamlobler as per our conversation we agreed to change the bg token value in the new light and dark themes to transparent. this PR will stay open until the token change to double check the result. let us know when that's done

I has been fixed and merged to master, if you rebase it should have a transpaent bg in the new themes.

@git-nandor git-nandor merged commit 066524f into master Apr 1, 2026
10 of 12 checks passed
@git-nandor git-nandor deleted the Byline_rework branch April 1, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants