Conversation
|
cc5dbda to
df9f4df
Compare
|
@git-nandor I think commit should include that this a breaking change too because of the theming engine |
adamlobler
left a comment
There was a problem hiding this comment.
Byline is a component that can be used on any kind of surface. Right now, it has a background color that might differ from the surface it’s placed on. I would remove this background color to prevent these weird edge cases.
Can we do that @matyasf ?
@adamlobler as per our conversation we agreed to change the bg token value in the new light and dark themes to transparent. this PR will stay open until the token change to double check the result. let us know when that's done |
I has been fixed and merged to master, if you rebase it should have a transpaent bg in the new themes. |
df9f4df to
09eef4b
Compare

INSTUI-4966
Rework Byline
Test:
Check doc Byline page.