Skip to content

feat(ui-date-input): add missing role and aria-label to DateInput2 di…#2404

Merged
ToMESSKa merged 1 commit intomasterfrom
INSTUI-4915-a-11-date-input-2-missing-role-dialog
Feb 13, 2026
Merged

feat(ui-date-input): add missing role and aria-label to DateInput2 di…#2404
ToMESSKa merged 1 commit intomasterfrom
INSTUI-4915-a-11-date-input-2-missing-role-dialog

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Feb 12, 2026

…alog

INSTUI-4915

ISSUE:

  • DateInput2 is missing role="dialog" and a descriptive aria-label on the dialog element

TEST PLAN:

  • go to the DateInput2 examples
  • open the date picker dialog with a screen reader
  • the screen reader should announce it as a "dialog" and include its name, e.g., "date picker"
  • examine the HTML — the span containing the date picker should have role="dialog" and an aria-label attribute

@ToMESSKa ToMESSKa self-assigned this Feb 12, 2026
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-02-13 11:32 UTC

@ToMESSKa ToMESSKa changed the title feat(ui-date-input): add missing role and aria-label to DateInput2 di… fix(ui-date-input): add missing role and aria-label to DateInput2 di… Feb 12, 2026
@ToMESSKa ToMESSKa requested review from balzss and matyasf February 12, 2026 12:19
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark this commit as feat: since we're kinda adding a new feature

@ToMESSKa ToMESSKa changed the title fix(ui-date-input): add missing role and aria-label to DateInput2 di… feat(ui-date-input): add missing role and aria-label to DateInput2 di… Feb 13, 2026
@ToMESSKa ToMESSKa force-pushed the INSTUI-4915-a-11-date-input-2-missing-role-dialog branch from e2f5d86 to a49585e Compare February 13, 2026 08:11
@ToMESSKa ToMESSKa requested a review from matyasf February 13, 2026 08:23
@ToMESSKa ToMESSKa merged commit 6f2219a into master Feb 13, 2026
10 of 11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4915-a-11-date-input-2-missing-role-dialog branch February 13, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants