Skip to content

ci: Switch to python 3.12 as default target #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
booxter wants to merge 1 commit into from
Closed

ci: Switch to python 3.12 as default target #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
221 changes: 0 additions & 221 deletions .github/workflows/e2e-nvidia-l40s-x4-py312.yml
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions .github/workflows/e2e-nvidia-l40s-x4-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
run: |
cat /etc/os-release
mkdir -p "${TMPDIR}"
sudo dnf install -y gcc gcc-c++ make git python3.11 python3.11-devel
sudo dnf install -y gcc gcc-c++ make git python3.12 python3.12-devel

- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -130,18 +130,18 @@ jobs:
export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/usr/local/cuda/lib64:/usr/local/cuda/extras/CUPTI/lib64"
export PATH="$PATH:$CUDA_HOME/bin"
nvidia-smi
python3.11 -m venv --upgrade-deps venv
python3.12 -m venv --upgrade-deps venv
. venv/bin/activate
pip install instructlab
pip install instructlab[cuda]
pip install vllm
python3.11 -m pip install packaging wheel setuptools-scm
python3.12 -m pip install packaging wheel setuptools-scm
pip install .
pip install .[cuda]
python3.11 -m pip uninstall -y flash-attn
python3.11 -m pip cache purge
python3.11 -m pip install ninja
MAX_JOBS=8 python3.11 -m pip install flash-attn --no-build-isolation
python3.12 -m pip uninstall -y flash-attn
python3.12 -m pip cache purge
python3.12 -m pip install ninja
MAX_JOBS=8 python3.12 -m pip install flash-attn --no-build-isolation

- name: Check disk before tests
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-nvidia-l40s-x4.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: Apache-2.0

name: E2E (NVIDIA L40S x4) (python 3.11)
name: E2E (NVIDIA L40S x4) (python 3.12)

on:
schedule:
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
- name: Run e2e tests
uses: ./training/.github/actions/run-e2e
with:
python-version: 3.11
python-version: 3.12
gh-token: ${{ secrets.GITHUB_TOKEN }}
hf-token: ${{ secrets.HF_TOKEN }}
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ jobs:
# https://github.com/actions/checkout/issues/249
fetch-depth: 0

- name: Setup Python 3.11
- name: Setup Python 3.12
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: 3.11
python-version: 3.12
cache: pip
cache-dependency-path: |
**/pyproject.toml
Expand Down
Loading
Loading