Feature/296 add community pages #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marta-tomzik
commented
Oct 23, 2024
marta-tomzik
commented
- added community pages with short description
- exported hardware requirements to separate file and created links. When this is merged, the specs file will be linked in the main InstructLab repo.
Contributor
|
This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days. |
dominikkawka
reviewed
Jan 6, 2025
Member
dominikkawka
left a comment
dominikkawka
left a comment
There was a problem hiding this comment.
sorry for the late review, lgtm!
please sign the commits to let the DCO pass
jjasghar
approved these changes
Jan 16, 2025
Contributor
|
Please fix the DCO, then we can merge this. |
Signed-off-by: Marta Tomzik <marta.tomzik@ibm.com>
Signed-off-by: Marta Tomzik <marta.tomzik@ibm.com>
marta-tomzik
force-pushed
the
feature/296-add-community-pages
branch
from
6d58688 to
1b5d800
Compare
Contributor
Author
|
fixed! :) |
Contributor
|
Please take a look at the checks, and fix the merge conflicts, you'll probably have to rebase :) |
Signed-off-by: Marta Tomzik <marta.tomzik@ibm.com>
Signed-off-by: Marta Tomzik <marta.tomzik@ibm.com>
Signed-off-by: Marta Tomzik <marta.tomzik@ibm.com>
Contributor
Author
|
@jjasghar @dominikkawka I've fixed everything, probably the spellcheck will fail again because of the service names that I used. |
dominikkawka
approved these changes
Mar 3, 2025
Member
|
@dominikkawka in the future, please have contributors add words to the dictionary instead of overriding CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.