chore(deps): bump postgres from 16-alpine to 17-alpine (matches inkeep cloud)#2237
Conversation
Bumps postgres from 16-alpine to 18-alpine. --- updated-dependencies: - dependency-name: postgres dependency-version: 18-alpine dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
PR Review Summary
(1) Total Issues | Risk: Medium
🟠⚠️ Major (1) 🟠⚠️
🟠 1) create-agents-template/ Version drift: Self-hosting templates still at postgres:16-alpine
files:
create-agents-template/docker-compose.yml:142create-agents-template/docker-compose.db.yml:65
Issue: This PR updates the SpiceDB backing Postgres from 16-alpine to 17-alpine in the monorepo's docker-compose files, but leaves the create-agents-template/ files at 16-alpine. This creates version drift between the local dev environment and the scaffolded template that customers use for self-hosting.
Why: Version drift between the dev environment and customer-facing templates can cause subtle bugs when customers deploy with different Postgres versions than contributors test against. The self-hosting artifacts should stay in sync with the local dev stack to ensure consistent behavior.
Fix: Update the following files to use postgres:17-alpine:
create-agents-template/docker-compose.ymlline 142create-agents-template/docker-compose.db.ymlline 65
Refs:
💭 Consider (1) 💭
💭 1) PR metadata PR title/description mismatch
Issue: The PR title states "bump postgres from 16-alpine to 18-alpine" but the actual changes show 16-alpine → 17-alpine. The commit history reveals the original Dependabot bump to 18-alpine was manually downgraded to 17-alpine.
Why: PR titles often appear in changelogs and merge commits. The current title may mislead readers about the actual deployed version.
Fix: Consider updating the PR title to: chore(deps): bump spicedb-postgres from 16-alpine to 17-alpine
🚫 REQUEST CHANGES
Summary: This is a straightforward Postgres version bump for the SpiceDB backing database. The change itself looks good, but the create-agents-template/ files should be updated alongside to maintain consistency between the dev environment and customer self-hosting templates. Once those files are updated, this PR is ready to merge.
Discarded (2)
| Location | Issue | Reason Discarded |
|---|---|---|
docker-compose.dbs.yml:65 |
Mutable Docker tag (17-alpine) instead of pinned digest |
Pre-existing pattern — postgres:18 is also unpinned. Not introduced by this PR. |
docker-compose.dbs.yml |
Version asymmetry (main DB at 18, SpiceDB at 17) | Appears intentional — explicit downgrade commits in history suggest compatibility reasons. |
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-devops |
4 | 1 | 1 | 0 | 0 | 0 | 2 |
| Total | 4 | 1 | 1 | 0 | 0 | 0 | 2 |
Ito Test Report ❌15 test cases ran. 13 passed, 2 failed. This test run verified the SpiceDB Postgres upgrade from ✅ Passed (13)❌ Failed (2)EDGE-1: Existing Postgres 16 volume compatibility with Postgres 17 – Failed
EDGE-5: create-agents-template still uses postgres:16-alpine — version inconsistency – Failed
📋 View Recording |















Bumps postgres from 16-alpine to 17-alpine.