Skip to content

python-packaging: honor add_context.include for non-stdlib extensions #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dae wants to merge 1 commit into
base: main
Choose a base branch
from
Open

python-packaging: honor add_context.include for non-stdlib extensions #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyoxidizer/docs/pyoxidizer_config_type_python_extension_module.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@
(various)

See :ref:`config_resource_add_attributes`.

Note: `add_include` is currently ignored for builtin modules, and can not
be used to control their inclusion.
8 changes: 4 additions & 4 deletions python-packaging/src/resource_collection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,10 +1301,10 @@ impl PythonResourceCollector {
extension_module: &PythonExtensionModule,
add_context: &PythonResourceAddCollectionContext,
) -> Result<Option<LibPythonBuildContext>> {
// TODO consult this attribute (it isn't set for built-ins for some reason)
//if !add_context.include {
// return Ok(None);
// }
// TODO: investigate why `include` is always false for stdlib modules
if !add_context.include && !extension_module.is_stdlib {
return Ok(None);
}

// Whether we can load extension modules as standalone shared library files.
let can_load_standalone = self
Expand Down