Skip to content

Conversation

@ryancinsight
Copy link
Contributor

I downloaded most recent version of pyoxidizer and have been trying to install but ran into crates for apple potions of code failing on windows, can we please make the apple portion config optional on windows, this is minimum I had to do to work on windows as a start.

@ryancinsight ryancinsight marked this pull request as draft August 6, 2021 13:27
@ryancinsight
Copy link
Contributor Author

@indygreg this was minimum working example to compile without apple crates on windows, though looks like your CI is more stringent than my laptop. Ill look at other configurations and better ways of doing when I get a chance but was hoping you would see this and reduce number of scripts actually determining build rather than using cfg options. its quite considerable the number of packages on windows alone and I can reduce by almost 100 cfg masking apple crates

@indygreg
Copy link
Owner

indygreg commented Aug 7, 2021

What's the exact build problem you are trying to fix?

@ryancinsight
Copy link
Contributor Author

With Rust 1.53 I was needing to change some of the features on the crates currently being used to allow compatibility on older windows 7 laptops. Specifically with snmalloc in this case with win8compat feature. This requires generating a new lock file but I couldn't inability to find compatible crates with AES crate, tugged apple, crypto crates. So to generate a new lock file I had to cfg mask crates related to Apple which I'm not sure we need to compile on windows in the first place. It's a considerable number of packages on windows, if I remember correctly it went from 600 to 501 crates being compiled.

@indygreg indygreg force-pushed the main branch 3 times, most recently from 8f998b7 to 5c5ac33 Compare December 1, 2021 03:16
@indygreg indygreg force-pushed the main branch 2 times, most recently from 5e0524b to 789c62e Compare May 31, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants