Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds # noqa: RUF069 comments to suppress false positive warnings from Ruff's RUF069 linting rule, which flags explicit type conversions in comparisons as potentially redundant. The suppressions are applied to cases where the explicit conversions are semantically meaningful and necessary.
Changes:
- Added noqa comments to suppress RUF069 warnings for symbolic expression comparisons in tests
- Added noqa comments for physical constant validations in kernel classes
- Added noqa comment for precision-loss checking in complex number conversion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sumpy/test/test_kernels.py | Suppressed RUF069 for two assertions that convert symbolic expressions to floats before comparing to 0.0 |
| sumpy/kernel.py | Suppressed RUF069 for Poisson ratio comparisons with 0.5 in ElasticityKernel and StokesletKernel |
| sumpy/codegen.py | Suppressed RUF069 for complex64 precision check that compares converted value back to original |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.