Cleanup #3
Cleanup #3
Conversation
Copying the RNG is not part of this test. It is tested in pcg-test.cpp
Because this is a test build all warnings (except compat) are helpful. They may be used to increase the quality of the library.
|
Thanks for your work! To facilitate some projects using PCG, I'm considering switching the code to an MIT license. Is it okay for all contributions you make to the project to be licensed under that license instead? Some of your changes fix bugs, but some seem like a matter of taste and change the semantics of the code. The former are no-brainers. The latter require a bit more persuasion. |
This reverts commit a88a015.
This should work on all versions of make. Thanks to stackoverflow for this idea: https://stackoverflow.com/a/1328441/1718219
|
I've started to address some of you comments, for the others I'm waiting for your feedback. I'm totally fine with the upcoming switch to the MIT license. |
|
Feel free to throw in another set of comments. I'm not in town until Tuesday, so I'll address possible issues next week. |
|
Back at work :) |
|
I've applied almost all your changes, although I used a cherry-pick strategy so I could avoid some the changes that you applied and then undid. Thanks for your help. |
What's the status of this? Would love to port this to Julia, but MIT would be a much more preferable license vs Apache. |
|
Tell you what, if you write the patch to change the licenses in all the files etc. (all PCG dists), I'll apply it. Otherwise, it'll wait until I have a moment to do it, which should be next week, but I've been thinking that for the last month. Thanks, Sent on the go, via iPad, wireless networks, and other modern technology
|
|
@imneme can we close this? |
|
Is there any update here? Is there any reason for not switching to the MIT License? |
4 participants
I have enabled some helpful compiler warnings and started to fix some problems, which you find in separate commits. Especially clang was really helpful here. There are still some possible bugs left which I plan to fix later (mostly some sign conversions and conditionally uninitialized variables).