Fix set_stream to use unsigned integer for inc_; Workaround for Windo… #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws SDK header conflicts in pcg-cpp The build was failing on Windows (MSVC) with error C2678 due to ambiguous 'operator|' calls. Root cause: Windows SDK headers (winuser.h, winnt.h, etc.) define multiple operator| overloads for various enums. When using a literal integer '1' with pcg_extras types, the compiler cannot distinguish between PCG's custom operators and Windows' enum operators. Solution: Explicitly cast the literal to 'itype' to resolve the ambiguity. This ensures the compiler selects the correct operator defined in pcg-cpp while maintaining full cross-platform compatibility for Linux and macOS.
Author
|
Merged into Total-Random/pcg-cpp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ws SDK header conflicts in pcg-cpp
The build was failing on Windows (MSVC) with error C2678 due to ambiguous 'operator|' calls.
Root cause: Windows SDK headers (winuser.h, winnt.h, etc.) define multiple operator| overloads for various enums. When using a literal integer '1' with pcg_extras types, the compiler cannot distinguish between PCG's custom operators and Windows' enum operators.
Solution: Explicitly cast the literal to 'itype' to resolve the ambiguity. This ensures the compiler selects the correct operator defined in pcg-cpp while maintaining full cross-platform compatibility for Linux and macOS.