Merged
Conversation
kkysen
requested changes
Mar 4, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Thanks for working on this! It seems, though, that there are a bunch more subtle things missing, some of which you've covered and brought to our attention, but there's still some more, and I suggested some other organizational changes, too.
cydparser
force-pushed
the
dedup-keywords
branch
3 times, most recently
from
241ec73 to
9ff5180
Compare
kkysen
reviewed
Mar 15, 2026
kkysen
reviewed
Mar 15, 2026
kkysen
reviewed
Mar 15, 2026
kkysen
reviewed
Mar 15, 2026
kkysen
approved these changes
Mar 15, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
This generally LGTM besides a few comments. Thanks! Also, can you remove the .expect_compile_error_edition_2024(true) line in c2rust-transpile/tests/snapshots.rs after rebasing? This fixes that issue with gen.
15 tasks
cydparser
force-pushed
the
dedup-keywords
branch
from
9ff5180 to
23bfd98
Compare
Contributor
Author
|
@kkysen, thanks for the reviews. I think all requested changes have been made. |
kkysen
reviewed
Mar 16, 2026
kkysen
reviewed
Mar 16, 2026
kkysen
requested changes
Mar 16, 2026
kkysen
approved these changes
Mar 19, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
I fixed the couple of little remaining issues myself. Merging now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change extracts keywords into
c2rust-transpile::RUST_KEYWORDSand reduces the amount of renaming in a few places. If I have understood the code correctly,RESERVED_NAMESshould have only been used when renaming types, but it was also being used when renaming field names and module names.