fix: add optional chaining to patch access in applyPatches for noUncheckedIndexAccess#1240
Open
mixelburg wants to merge 1 commit into
Open
fix: add optional chaining to patch access in applyPatches for noUncheckedIndexAccess#1240mixelburg wants to merge 1 commit into
mixelburg wants to merge 1 commit into
Conversation
…eckedIndexAccess compatibility When TypeScript projects use , array indexing returns . The variable from can be even though the loop bounds are correct, causing a type error: 'patch' is possibly 'undefined' This adds optional chaining (, ) to resolve the type error without changing runtime behavior, since the loop bounds already guarantee the value is defined. Fixes immerjs#1143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When TypeScript projects use
noUncheckedIndexAccess: true, array indexing returnsT | undefined. Thepatchvariable frompatches[i]inapplyPatchescan beundefinedeven though the loop bounds are correct, causing a type error:This adds optional chaining (
patch?.path,patch?.op) to resolve the type error without changing runtime behavior.Changes
src/core/immerClass.ts: Added optional chaining topatch.pathandpatch.opaccesses inapplyPatchesmethod.Context
This is a minimal, non-breaking change. The loop bounds already guarantee the value is defined at runtime. All 3651 existing tests pass.
Fixes #1143