Skip to content

Conversation

@tgurr
Copy link
Contributor

@tgurr tgurr commented May 13, 2025

Fixes CMake >= 4.0.0 build failure:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

Copy link
Member

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is fine as it stands.

Though the CI run reveals that, unrelated to this PR, our CI has rusted away a bit and is failing because the GHA runners themselves have broken things. We need to update the CI workflow, much like we did for other projects a couple months back, to do the trick to make the right npm still work with the old ASWF images (or just switch to newer images).

@grdanny grdanny merged commit f7cdd17 into imageworks:master May 14, 2025
6 of 25 checks passed
@tgurr tgurr deleted the cmake-4.0 branch May 14, 2025 07:54
@LecrisUT
Copy link

LecrisUT commented Aug 5, 2025

  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

This is actually the preferred approach, particularly use <max> with the highest version in the CI. This will reduce the downstream maintenance when the next round of deprecation hits in a couple of years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants