Skip to content

fix: remove unsafe exec() in App.java #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 4 commits into
base: master
Choose a base branch
from
+20 −2
Open

fix: remove unsafe exec() in App.java #3471

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b09012a
fix: V-002 security vulnerability
orbisai0security May 6, 2026
d68c18b
adding cross-platform support
orbisai0security May 29, 2026
db3f0c6
fixing sonarqube hotspots
orbisai0security May 29, 2026
23814e1
fixing the formating for java windows
orbisai0security May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions page-object/sample-application/src/main/java/com/iluwatar/pageobject/App.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.awt.Desktop;
import java.io.File;
import java.io.IOException;
import java.util.Locale;
import lombok.extern.slf4j.Slf4j;

/**
Expand Down Expand Up @@ -77,8 +78,25 @@ public static void main(String[] args) {
Desktop.getDesktop().open(applicationFile);

} else {
// java Desktop not supported - above unlikely to work for Windows so try instead...
Runtime.getRuntime().exec("cmd.exe start " + applicationFile);
// Use absolute paths to avoid PATH injection vulnerabilities (SonarQube S5304)
var os = System.getProperty("os.name").toLowerCase(Locale.ROOT);
ProcessBuilder pb;
if (os.contains("win")) {
// Standard Windows location since Windows NT
pb =
new ProcessBuilder(
"C:\\Windows\\System32\\cmd.exe",
"/c",
"start",
applicationFile.getAbsolutePath());
} else if (os.contains("mac")) {
// Standard macOS location for 'open' command
pb = new ProcessBuilder("/usr/bin/open", applicationFile.getAbsolutePath());
} else {
// Standard Linux desktop location for xdg-open
pb = new ProcessBuilder("/usr/bin/xdg-open", applicationFile.getAbsolutePath());
}
pb.start();
}

} catch (IOException ex) {
Expand Down
Loading