Open
Conversation
PR SummaryAdds JavaDoc for singleton instance method; updates READMEs to reflect usage notes (event-driven observer implications and database connection example); clarifies IvoryTower singleton behavior with explicit getInstance() documentation. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (3)
Files Processed (3)
- observer/README.md (1 hunk)
- singleton/README.md (1 hunk)
- singleton/src/main/java/com/iluwatar/singleton/IvoryTower.java (2 hunks)
Actionable Comments (0)
Skipped Comments (4)
-
observer/README.md [177-177]
readability: "Add usage context for Observer pattern"
-
singleton/README.md [81-81]
readability: "Improve README bullet for database singleton example"
-
singleton/src/main/java/com/iluwatar/singleton/IvoryTower.java [27-31]
readability: "Document singleton class contract"
-
singleton/src/main/java/com/iluwatar/singleton/IvoryTower.java [50-56]
readability: "Improve Javadoc for getInstance()"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added JavaDoc comments to improve clarity of the Singleton implementation.
This change enhances code readability by explaining the purpose of the getInstance() method and how it ensures a single instance throughout the application.