Fix: Update Gemini model version in presubmit.yml#3339
Fix: Update Gemini model version in presubmit.yml#3339prem-2006 wants to merge 3 commits intoiluwatar:masterfrom
Conversation
The Presubmit.ai check was failing due to an outdated Gemini model version. Updated LLM_MODEL from "gemini-1.5-flash" to "gemini-1.5-flash-latest" to fix the issue.
PR SummaryFixes a failing Presubmit.ai check by updating Gemini model version in the presubmit workflow. Updates the PR trigger types, removes an unnecessary secret check, switches to latest checkout action, and prints a completion message. Changes
autogenerated by presubmit.ai |
|
Updated pull request event types and removed secret check step. Modified AI reviewer step to include new environment variables.
|
This PR is stale because it has been open 60 days with no activity. |
Refactor presubmit workflow for AI code review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (3)
Refactor presubmit workflow for AI code review
- 16eeea7: Refactor presubmit workflow for AI code review
Updated pull request event types and removed secret check step. Modified AI reviewer step to include new environment variables.
The Presubmit.ai check was failing due to an outdated Gemini model version.
Updated LLM_MODEL from "gemini-1.5-flash" to "gemini-1.5-flash-latest" to fix the issue.
Files Processed (1)
- .github/workflows/presubmit.yml (1 hunk)
Actionable Comments (1)
-
.github/workflows/presubmit.yml [20-26]
possible_bug: "Ensure YAML env mapping is valid"
Skipped Comments (3)
-
.github/workflows/presubmit.yml [10-10]
enhancement: "Update PR event types"
-
.github/workflows/presubmit.yml [17-18]
best_practice: "Add repository checkout step"
-
.github/workflows/presubmit.yml [28-29]
best_practice: "Completion message"
| - name: Run AI code reviewer | ||
| uses: presubmit/ai-reviewer@latest | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| LLM_API_KEY: ${{ secrets.LLM_API_KEY }} | ||
| LLM_MODEL: "gemini-1.5-flash" | ||
| LLM_PROVIDER: ai-sdk | ||
| LLM_MODEL: gemini-1.5-flash-latest # ✅ Updated model | ||
| REVIEW_SUMMARY: "true" | ||
| MAX_TOKENS: "4096" |
There was a problem hiding this comment.
This block configures the AI reviewer task. However, ensure the env block is properly formed under the step (use env: with a mapping of variables). The snippet currently shows an 'env' line with a possible formatting issue (env + LLM_PROVIDER...). Correct it to:\n env:\n LLM_PROVIDER: ai-sdk\n LLM_MODEL: gemini-1.5-flash-latest\n REVIEW_SUMMARY: "true"\n MAX_TOKENS: "4096"\n TEMPERATURE: "0.2"
|
1 participant
Summary
Fixes the failing Presubmit.ai check caused by an outdated Gemini model version.
Changes Made
LLM_MODELfromgemini-1.5-flashtogemini-1.5-flash-latestin.github/workflows/presubmit.yml.Related Issue
Fixes #3337