Add Microservices Bulkhead pattern implementation (#3228)#3326
Open
beingadish wants to merge 8 commits into
Open
Add Microservices Bulkhead pattern implementation (#3228)#3326beingadish wants to merge 8 commits into
beingadish wants to merge 8 commits into
Conversation
- Implements resource isolation with dedicated thread pools - Demonstrates fail-fast behavior under load - Fixes iluwatar#3228
PR SummaryImplemented resource isolation with dedicated thread pools ( Changes
autogenerated by presubmit.ai |
|
|
This PR is stale because it has been open 60 days with no activity. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (2)
Files Processed (8)
- microservices-bulkhead/README.md (1 hunk)
- microservices-bulkhead/pom.xml (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/App.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BackgroundService.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BulkheadService.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/Task.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/TaskType.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/UserService.java (1 hunk)
Actionable Comments (0)
Skipped Comments (5)
-
microservices-bulkhead/pom.xml [2-9]
best_practice: "License header cleanliness in module pom"
-
microservices-bulkhead/pom.xml [68-73]
maintainability: "Unneeded Lombok dependency in module"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BulkheadService.java [85-97]
enhancement: "Blocking sleep in worker thread"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BackgroundService.java [31-37]
enhancement: "Background rejection handling lacks specific logic"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/UserService.java [32-37]
enhancement: "User service rejection handling lacks user-facing fallback"
Author
|
Hi @iluwatar , kindly merge this PR |
iluwatar
requested changes
Jun 7, 2026
iluwatar
left a comment
iluwatar
left a comment
Owner
There was a problem hiding this comment.
Add the new module to parent pom.xml, otherwise it's not built by CI at all.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 068950a: Merge branch 'iluwatar:master' into feature/microservices-bulkhead
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
* Remove `org.projectlombok:lombok` dependency. * Add explicit version `3.27.7` to the `org.assertj:assertj-core` test dependency.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (5)
- 59d1228: build: update dependencies in microservices-bulkhead
- Remove
org.projectlombok:lombokdependency. - Add explicit version
3.27.7to theorg.assertj:assertj-coretest dependency.
-
d812403: build: add microservices-bulkhead module to root pom
-
068950a: Merge branch 'iluwatar:master' into feature/microservices-bulkhead
-
da16647: Merge branch 'master' into feature/microservices-bulkhead
-
0dc5355: Add Microservices Bulkhead pattern implementation
-
Implements resource isolation with dedicated thread pools
-
Demonstrates fail-fast behavior under load
-
Fixes #3228
Files Processed (9)
- microservices-bulkhead/README.md (1 hunk)
- microservices-bulkhead/pom.xml (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/App.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BackgroundService.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BulkheadService.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/Task.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/TaskType.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/UserService.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BulkheadService.java [67-78]
enhancement: "Clarify and extend the rejection path for observability"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BackgroundService.java [31-37]
enhancement: "Background rejection hook could implement fallback"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/UserService.java [31-37]
enhancement: "User rejection handling could expose a user-facing fallback"
Refactor all core classes and add comprehensive test coverage for the Microservices Bulkhead pattern. Refactored: - BulkheadService: overhaul thread pool isolation logic - App: update demo to reflect revised service APIs - BackgroundService, UserService: align with updated BulkheadService - Task, TaskType: revise model structure and toString representation - pom.xml: update module dependency configuration Added tests: - AppTest: verifies main entry point runs without exception - BulkheadServiceTest: task acceptance, overflow rejection, active thread count, queue size reporting, and graceful shutdown - BackgroundServiceTest: task submission, bulkhead overflow, and isolation from UserService overload - UserServiceTest: user request acceptance and isolation from overloaded BackgroundService - TaskTest: name, type, duration getters and toString format - TaskTypeTest: enum values USER_REQUEST and BACKGROUND_PROCESSING
- Task: used Lombok @Getter
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (2)
- c1951c4: Refactored:
- Task: used Lombok @Getter
- 73fe983: feat(microservices-bulkhead): refactor implementation and add unit tests
Refactor all core classes and add comprehensive test coverage for the
Microservices Bulkhead pattern.
Refactored:
- BulkheadService: overhaul thread pool isolation logic
- App: update demo to reflect revised service APIs
- BackgroundService, UserService: align with updated BulkheadService
- Task, TaskType: revise model structure and toString representation
- pom.xml: update module dependency configuration
Added tests:
- AppTest: verifies main entry point runs without exception
- BulkheadServiceTest: task acceptance, overflow rejection, active thread
count, queue size reporting, and graceful shutdown - BackgroundServiceTest: task submission, bulkhead overflow, and isolation
from UserService overload - UserServiceTest: user request acceptance and isolation from overloaded
BackgroundService - TaskTest: name, type, duration getters and toString format
- TaskTypeTest: enum values USER_REQUEST and BACKGROUND_PROCESSING
Files Processed (14)
- microservices-bulkhead/pom.xml (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/App.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BackgroundService.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BulkheadService.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/Task.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/TaskType.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/UserService.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/AppTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/BackgroundServiceTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/BulkheadServiceTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/TaskTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/TaskTypeTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/UserServiceTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (2)
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/Task.java [14-16]
best_practice: "Missing Lombok dependency for Task model"
-
microservices-bulkhead/pom.xml [68-74]
test: "JUnit 5 API dependency missing"
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 9d51b47: style: add license headers and apply Google Java Format
Files Processed (12)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/App.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BackgroundService.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BulkheadService.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/Task.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/TaskType.java (1 hunk)
- microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/UserService.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/AppTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/BackgroundServiceTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/BulkheadServiceTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/TaskTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/TaskTypeTest.java (1 hunk)
- microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/UserServiceTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (12)
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/Task.java [1-45]
maintainability: "Lombok usage for Task"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BulkheadService.java [1-159]
maintainability: "BulkheadService rationale and capabilities"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/BackgroundService.java [1-57]
maintainability: "BackgroundService rationale and delegation"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/App.java [1-138]
maintainability: "App entry point demonstrating the Microservices Bulkhead"
-
microservices-bulkhead/src/main/java/com/iluwatar/bulkhead/TaskType.java [1-36]
maintainability: "TaskType enum structure"
-
microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/AppTest.java [1-32]
maintainability: "AppTest invokes App.main"
-
microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/BulkheadServiceTest.java [1-80]
maintainability: "BulkheadService basic tests"
-
microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/BackgroundServiceTest.java [1-73]
maintainability: "BackgroundServiceTest overview"
-
microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/AppTest.java [1-32]
maintainability: "AppTest invokes App.main"
-
microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/TaskTest.java [1-54]
maintainability: "Task unit tests"
-
microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/TaskTypeTest.java [1-44]
maintainability: "TaskType enum tests"
-
microservices-bulkhead/src/test/java/com/iluwatar/bulkhead/BulkheadServiceTest.java [1-80]
maintainability: "BulkheadService basic tests"
Owner
|
@beingadish consider rebasing on top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3228