Fix missing scaling for plugin view drag & mouse events #17
Closed
emuell wants to merge 1 commit into
Closed
Conversation
Owner
|
Hey, this feels like the wrong place to do this. I added a new branch to pre-scale mouse event coordinates at plugin-canvas level and removed the scaling code from plugin-canvas-slint: https://github.com/ilmai/plugin-things/tree/mouse-event-scaling I implemented it for Mac now and will add Linux and Windows implementations later today. |
Contributor
Author
|
Yep, that's definitely cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Events sent to
PluginViewimpls, should send positions as logical view positions, applying OS window scale and custom canvas scales, just like events sent to slint.The MouseXXX events are unlikely to be used in plugin_view, but it makes sense to convert them too, for consistency. I needed this for the drag events only.
The new
with_mapped_positionis mildly ugly. :) Let me know if you prefer something else here.