Possible crash to assign tableView properties before calling showTable#10
Open
yoon-boom wants to merge 5 commits intoigongora:masterfrom
Open
Possible crash to assign tableView properties before calling showTable#10yoon-boom wants to merge 5 commits intoigongora:masterfrom
showTable#10yoon-boom wants to merge 5 commits intoigongora:masterfrom
Conversation
Owner
|
I'm glad you like it!. I'll check it out your pull request and merge it after review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for providing great dropdown API. I have noticed that the tableview being allocated and inserted every time
showTable()being called. Inserting view could be potentially heavy lifting, how about allocate instance once in thesetup()and use the UIView'shideproperty? Also, by fixing this, API callee can access tableview's properties (currently bug) such as background color, layer border width, etc before even it being displays.