Skip to content

Update survey roadmap: mark 10b shipped, add 10e simulation details#275

Merged
igerber merged 1 commit intomainfrom
docs/survey-roadmap-phase10-update
Apr 5, 2026
Merged

Update survey roadmap: mark 10b shipped, add 10e simulation details#275
igerber merged 1 commit intomainfrom
docs/survey-roadmap-phase10-update

Conversation

@igerber
Copy link
Copy Markdown
Owner

@igerber igerber commented Apr 5, 2026

Summary

  • Mark Phase 10b (research-grade survey DGP) as shipped with parameter summary
  • Add four specific simulation study scenarios for 10e position paper, including conditional PT as a required DGP extension
  • Genericize co-authorship suggestion in 10e (no specific names)

Methodology references

  • N/A — documentation only, no methodology code changes

Validation

  • No test changes — documentation only

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

- Mark Phase 10b (research-grade DGP) as shipped with parameter summary
- Add conditional PT as required DGP extension for position paper (10e)
  simulation study — unconditional PT fails, conditional PT holds after
  covariate adjustment, DR/IPW recovers truth
- Genericize co-authorship suggestion (no specific names)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

Overall Assessment

✅ Looks good

Executive Summary

  • This is a documentation-only PR in docs/survey-roadmap.md#L140; I found no estimator, weighting, inference, or default-behavior code changes in scope.
  • The new “10b shipped” summary matches the implemented generate_survey_did_data() surface in diff_diff/prep_dgp.py#L1163 and the corresponding test coverage in tests/test_prep.py#L1512.
  • The methodology-specific details touched by the new text are already documented in the Methodology Registry at docs/methodology/REGISTRY.md#L2518, so I did not find any undocumented deviation.
  • The new 10e wording correctly treats conditional_pt as a missing future DGP extension rather than implying current support in docs/survey-roadmap.md#L148.
  • No code quality, performance, security, or documentation/test blockers were introduced by the diff.

Methodology

No findings.

Methods affected: none; this PR updates roadmap text only. The new 10b status is consistent with the implemented DGP parameters and behavior in diff_diff/prep_dgp.py#L1184, diff_diff/prep_dgp.py#L1258, and diff_diff/prep_dgp.py#L1670, plus existing tests in tests/test_prep.py#L1559, tests/test_prep.py#L1589, tests/test_prep.py#L1759, and tests/test_prep.py#L1792. The registry already documents the icc calibration and informative-sampling-with-covariates behavior in docs/methodology/REGISTRY.md#L2520 and docs/methodology/REGISTRY.md#L2526, so there is no undocumented mismatch.

The new 10e language also stays within documented methodology boundaries: it marks conditional_pt as future work in docs/survey-roadmap.md#L199, and it does not conflict with the already-documented conservative reg+covariates deviation in docs/survey-roadmap.md#L246 and docs/methodology/REGISTRY.md#L438.

Code Quality

No findings. Markdown-only edits; no new code paths or anti-patterns were introduced.

Performance

No findings. No runtime code changed.

Maintainability

No findings. The updated roadmap text is aligned with current implementation and existing methodology notes rather than creating a competing description.

Tech Debt

No findings. The only unresolved item introduced by the text is the future conditional_pt DGP extension, and it is explicitly tracked in the roadmap itself at docs/survey-roadmap.md#L148.

Security

No findings. No executable code, dependencies, secrets, or data-handling logic changed.

Documentation/Tests

No findings. No new tests are required for this docs-only PR, and the substantive roadmap assertions are already backed by existing DGP tests in tests/test_prep.py#L1512. Residual risk is limited to ordinary documentation drift because roadmap pages are manually maintained.

@igerber igerber merged commit e758f13 into main Apr 5, 2026
1 check passed
@igerber igerber deleted the docs/survey-roadmap-phase10-update branch April 5, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant