feat: upgrade next-js #22
Conversation
WalkthroughThe updates reactivate the fetching and display of import list data in the main application page by uncommenting relevant code. The Next.js package version is incremented, and a documentation URL in a TypeScript declaration file is updated. The "next-auth" package version specification is changed from a caret range to an exact version. No public APIs or exports are changed. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
collection/app/(app)/page.tsx (1)
17-22: 🛠️ Refactor suggestionFetch independent data concurrently to shave one full RTT off TTFB.
getAcademicYear,getAcademicYearsInDB, andgetImportListare independent DB calls. Fire them in parallel to cut server render time:- const currentAcademicYear = await getAcademicYear(); - const academicYears = await getAcademicYearsInDB(); - - const imports = await getImportList(); + const [currentAcademicYear, academicYears, imports] = await Promise.all([ + getAcademicYear(), + getAcademicYearsInDB(), + getImportList(), + ]);
🧹 Nitpick comments (3)
package.json (1)
84-84: Aligneslint-config-nextversion with upgraded Next.js.After bumping
nextto14.2.30, keepingeslint-config-nextlocked at14.2.3may cause peer-dependency warnings and miss out on lint rules added in the newer patch releases. Consider upgrading it in tandem:- "eslint-config-next": "14.2.3", + "eslint-config-next": "14.2.30",collection/next-env.d.ts (1)
4-6: Avoid manual edits to an auto-generated file.This file is regenerated by
next build/next dev; the comment tweak will be overwritten on the next run.
If you want to keep the doc link updated, add it to project docs or a separateREADMEinstead.collection/app/(app)/page.tsx (1)
30-31: Prop-drill the correct academic years prop name.
validAcaemicYearscontains a typo (Acaemic). Although not changed in this PR, the adjacent refactor highlights it. Fixing now prevents future bugs:- validAcaemicYears={academicYears} + validAcademicYears={academicYears}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
collection/app/(app)/page.tsx(3 hunks)collection/next-env.d.ts(1 hunks)package.json(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
collection/app/(app)/page.tsx (2)
collection/lib/crud/importCsv.ts (1)
getImportList(190-206)collection/app/(app)/ImportsList.tsx (1)
ImportsList(54-78)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: test
- GitHub Check: lint
- GitHub Check: build
|
@paulbalaji you accidentally installed your code review plugin into the docsoc org as well! |
Summary by CodeRabbit
New Features
Documentation
Chores