Fix GTFS+ handling #641
Merged
Fix GTFS+ handling #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br648
approved these changes
Dec 8, 2025
Contributor
br648
left a comment
br648
left a comment
There was a problem hiding this comment.
Sorry, my bad. This looks good. Should we have unit tests to cover this controller???
Contributor
Author
Contributor
Author
|
I am done with changes for this PR, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Fix #640 Blame #633
This PR addresses incorrect variable initialization in the GtfsPlusController class that prevents GTFS+ editing/publishing. It also adds missing try-with-resources blocks.