fix: stop enforcing SCONE as unique TEE framework for orders#244
Merged
abbesBenayache merged 3 commits intomainfrom Feb 16, 2026
Merged
fix: stop enforcing SCONE as unique TEE framework for orders#244abbesBenayache merged 3 commits intomainfrom
abbesBenayache merged 3 commits intomainfrom
Conversation
Contributor
abbesBenayache
commented
Feb 6, 2026
- Fetch app orderbook with minTag only (no maxTag) in sendEmail so existing ['tee','scone'] orders are still returned (iexec 8.22.5+).
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Fetch app orderbook with minTag only (no maxTag) in sendEmail so existing ['tee','scone'] orders are still returned (iexec 8.22.5+).
1e44fca to
a203e00
Compare
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
PierreJeanjacquot
approved these changes
Feb 16, 2026
Member
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
Implementation looks good
Need to fix tests:
web3mail.prepareEmailCampaign() › should prepare an email campaignRequest=> request order tag is now0x0000000000000000000000000000000000000000000000000000000000000001(tee only)- fetchApporderbook mock wrong tag format (see comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.