feat: add TDX TEE framework support#542
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
🐳 Hadolint Dockerfile Lint ResultsClick to expand detailed resultsDockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>` |
…ype validation - Fix version/fingerprint to use string().required() directly in objMrenclaveSchema - Make mrenclave optional in appSchema for TDX compatibility (SCONE deprecation planned)
a86ee41 to
10b3076
Compare
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
see comments for minor adjustments
- remove dead TDX fallback in teeFramework default - use generic app template for TDX - restore mrenclave validation behavior
07a6478 to
be6c2b2
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Note
Medium Risk
Touches order preflight validation and app TEE framework inference, which can affect whether orders are accepted/rejected and which SMS endpoint is used for secrets.
Overview
Adds TDX as a first-class
TeeFrameworkacross the SDK and CLI: updates tag encoding/decoding and validation to recognizetdx, and adjusts preflight checks so apps withoutmrenclaveare treated as TDX and can matchtee,tdxtags.Extends chain configuration to include a TDX SMS endpoint (notably on
arbitrum-sepolia-testnet), updatesiexec app init --tee-framework tdxto scaffold a non-mrenclaveapp template, and refreshes the default non-TEE app template image/checksum.Expands unit/e2e/CLI test coverage and local test docker-compose to run an additional
sms-tdxinstance, and updates docs/types to includetdx(plus minor type doc fixes aroundUint8Array/Buffergenerics).Written by Cursor Bugbot for commit 57bf118. This will update automatically on new commits. Configure here.