Profile card#4

Merged

hmdroh merged 9 commits intoiClasser:mainfrom

Khalidnoori568:profile-card

Sep 11, 2025

Collaborator

Khalidnoori568 commented Aug 20, 2025

postmaker dev - 2025-08-19T160716 674

Khalidnoori568 added 3 commits

August 13, 2025 16:45


          Add notebook-card

6e72ae7


          new update

4cefeb5


          profile card added

18d4642

vercel bot commented Aug 20, 2025

@Khalidnoori568 is attempting to deploy a commit to the iclasser dev Team on Vercel.

A member of the Team first needs to authorize it.

Collaborator

hmdroh commented Aug 22, 2025

test again

Collaborator

hmdroh commented Aug 22, 2025

can you resolve conflicts to see what has changed

hmdroh requested a review from Copilot

August 22, 2025 08:10

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull Request Overview

This PR introduces a comprehensive "Profile card" feature that includes multiple new components and updates to the existing X (Twitter) card editor. The changes add new card types including Profile, Notebook, and enhanced X cards, along with a modernized UI system using Radix UI components.

Adds new profile card component with image placeholder and customizable content fields
Introduces notebook-style card with checklist functionality and notebook-paper styling
Replaces Twitter card with enhanced X card featuring dynamic metrics and improved UI
Implements shared UI component system using Radix UI primitives and common form components

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`packages/ui/src/x-preview/x-preview.tsx`	Major refactor from Twitter to X branding with new interactive metrics and timestamp functionality
`packages/ui/src/profile-preview/profile-preview.tsx`	New profile card component with gradient background and image handling
`packages/ui/src/notebookcard-preview/notebook-preview.tsx`	New notebook-style card with checklist items and paper texture styling
`apps/web/components/x-editor.tsx`	Complete replacement of Twitter editor with enhanced X card editor featuring tabs and metrics
`apps/web/components/common/index.tsx`	New shared form components using Radix UI primitives
`apps/web/app/page.tsx`	Updated navigation to include new card types and URL-based tab management

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

packages/ui/src/x-preview/x-preview.tsx

+               } catch (error) {
+                  return num.toString();
+               }
               }

                
                    No newline at end of file

Copilot AI Aug 22, 2025

This file violates the custom coding guideline requiring new components to follow the proper structure. The X card editor should be in apps/web/components and this preview should be in packages/ui/src. While the preview is correctly placed, the editor logic (datetime handling) appears to be mixed into the preview component.

Copilot uses AI. Check for mistakes.

packages/ui/src/x-preview/x-preview.tsx

+                if (num < 1_000_000) return (num / 1000).toFixed(num % 1000 === 0 ? 0 : 1) + "k";
+                if (num < 1_000_000_000) return (num / 1_000_000).toFixed(num % 1_000_000 === 0 ? 0 : 1) + "m";
+                if (num < 1_000_000_000_000) return (num / 1_000_000_000).toFixed(num % 1_000_000_000 === 0 ? 0 : 1) + "b";
+                return (num / 1_000_000_000_000).toFixed(num % 1_000_000_000_000 === 0 ? 0 : 1) + "t";

Copilot AI Aug 22, 2025

The modulo operation num % 1000 === 0 will not work correctly for determining decimal places in formatted numbers. For example, 1500 % 1000 = 500 (not 0), so it would show '1.5k' instead of '2k'. The logic should check if the division result is a whole number.

Suggested change

      
              return (num / 1_000_000_000_000).toFixed(num % 1_000_000_000_000 === 0 ? 0 : 1) + "t";
          
              if (num < 1_000_000) return (num / 1000).toFixed((num / 1000) % 1 === 0 ? 0 : 1) + "k";
          
              if (num < 1_000_000_000) return (num / 1_000_000).toFixed((num / 1_000_000) % 1 === 0 ? 0 : 1) + "m";
          
              if (num < 1_000_000_000_000) return (num / 1_000_000_000).toFixed((num / 1_000_000_000) % 1 === 0 ? 0 : 1) + "b";
          
              return (num / 1_000_000_000_000).toFixed((num / 1_000_000_000_000) % 1 === 0 ? 0 : 1) + "t";

Copilot uses AI. Check for mistakes.

packages/ui/src/x-preview/x-preview.tsx

+               try {
+                 if (num < 1000) return num.toString();
+                if (num < 1_000_000) return (num / 1000).toFixed(num % 1000 === 0 ? 0 : 1) + "k";
+                if (num < 1_000_000_000) return (num / 1_000_000).toFixed(num % 1_000_000 === 0 ? 0 : 1) + "m";

Copilot AI Aug 22, 2025

Same modulo logic issue as above. num % 1_000_000 === 0 will not correctly determine when to show decimals. Should check if (num / 1_000_000) % 1 === 0 instead.

Suggested change

      
              if (num < 1_000_000_000) return (num / 1_000_000).toFixed(num % 1_000_000 === 0 ? 0 : 1) + "m";
          
              if (num < 1_000_000_000) return (num / 1_000_000).toFixed((num / 1_000_000) % 1 === 0 ? 0 : 1) + "m";

Copilot uses AI. Check for mistakes.

packages/ui/src/x-preview/x-preview.tsx

+                if (num < 1_000_000) return (num / 1000).toFixed(num % 1000 === 0 ? 0 : 1) + "k";
+                if (num < 1_000_000_000) return (num / 1_000_000).toFixed(num % 1_000_000 === 0 ? 0 : 1) + "m";
+                if (num < 1_000_000_000_000) return (num / 1_000_000_000).toFixed(num % 1_000_000_000 === 0 ? 0 : 1) + "b";
+                return (num / 1_000_000_000_000).toFixed(num % 1_000_000_000_000 === 0 ? 0 : 1) + "t";

Copilot AI Aug 22, 2025

Same modulo logic issue as above. The condition num % 1_000_000_000 === 0 will not work correctly for determining decimal places in the formatted output.

Suggested change

      
              return (num / 1_000_000_000_000).toFixed(num % 1_000_000_000_000 === 0 ? 0 : 1) + "t";
          
              if (num < 1_000_000) return (num / 1000).toFixed(Number.isInteger(num / 1000) ? 0 : 1) + "k";
          
              if (num < 1_000_000_000) return (num / 1_000_000).toFixed(Number.isInteger(num / 1_000_000) ? 0 : 1) + "m";
          
              if (num < 1_000_000_000_000) return (num / 1_000_000_000).toFixed(Number.isInteger(num / 1_000_000_000) ? 0 : 1) + "b";
          
              return (num / 1_000_000_000_000).toFixed(Number.isInteger(num / 1_000_000_000_000) ? 0 : 1) + "t";

Copilot uses AI. Check for mistakes.

packages/ui/src/x-preview/x-preview.tsx

+                if (num < 1_000_000) return (num / 1000).toFixed(num % 1000 === 0 ? 0 : 1) + "k";
+                if (num < 1_000_000_000) return (num / 1_000_000).toFixed(num % 1_000_000 === 0 ? 0 : 1) + "m";
+                if (num < 1_000_000_000_000) return (num / 1_000_000_000).toFixed(num % 1_000_000_000 === 0 ? 0 : 1) + "b";
+                return (num / 1_000_000_000_000).toFixed(num % 1_000_000_000_000 === 0 ? 0 : 1) + "t";

Copilot AI Aug 22, 2025

Same modulo logic issue as above. The condition for determining decimal places is incorrect and will not produce the expected formatting behavior.

Suggested change

      
              return (num / 1_000_000_000_000).toFixed(num % 1_000_000_000_000 === 0 ? 0 : 1) + "t";
          
              if (num < 1_000_000) return (num / 1000).toFixed(Number.isInteger(num / 1000) ? 0 : 1) + "k";
          
              if (num < 1_000_000_000) return (num / 1_000_000).toFixed(Number.isInteger(num / 1_000_000) ? 0 : 1) + "m";
          
              if (num < 1_000_000_000_000) return (num / 1_000_000_000).toFixed(Number.isInteger(num / 1_000_000_000) ? 0 : 1) + "b";
          
              return (num / 1_000_000_000_000).toFixed(Number.isInteger(num / 1_000_000_000_000) ? 0 : 1) + "t";

Copilot uses AI. Check for mistakes.

apps/web/components/common/index.tsx

+                      max={max}
+                      name={keyName}
+                      value={[value]}
+                      onValueChange={(val) => setStateValue(keyName, val)}

Copilot AI Aug 22, 2025

The Slider component returns an array of values, but the function is passing the entire array to setStateValue. This should extract the first value: onValueChange={(val) => setStateValue(keyName, val[0])}

Suggested change

      
                    onValueChange={(val) => setStateValue(keyName, val)}
          
                    onValueChange={(val) => setStateValue(keyName, val[0])}

Copilot uses AI. Check for mistakes.

apps/web/app/page.tsx

+              export default function Home() {
+                return (
+                  <Suspense fallback={<div>Loading...</div>}>

Copilot AI Aug 22, 2025

According to the coding guidelines, new components should have tabs added to apps/web/app/page.tsx. While tabs were added, the structure doesn't clearly follow the required pattern of having separate tabs for each new component (Profile card, Notebook card, and X card).

Copilot uses AI. Check for mistakes.

Khalidnoori568 added 6 commits

August 28, 2025 19:39


          changes

5248cb3


          new changes

1c52702


          resolved merge conflicts

5fe4912


          fix: update ESLint flat config and disable warnings for unused vars/any

6b93839


          Fix GitHub Actions workflow: install pnpm before running lint

d4ea19d


          Update lint script to ignore warnings

32c3231

vercel bot commented Sep 11, 2025 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
postmaker-dev-web	Ready	Preview	Comment	Sep 11, 2025 9:01am

vercel bot deployed to Preview

September 11, 2025 09:01

View deployment

hmdroh merged commit 3f30e35 into iClasser:main

2 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet