fix: Allow composer install on fresh clones (PHPUnit security advisory workaround)#357
Open
binaryfire wants to merge 1 commit intohypervel:mainfrom
Open
fix: Allow composer install on fresh clones (PHPUnit security advisory workaround)#357binaryfire wants to merge 1 commit intohypervel:mainfrom
binaryfire wants to merge 1 commit intohypervel:mainfrom
Conversation
- Add audit ignore for PKSA-z3gr-8qht-p93v (CVE-2026-24765) to allow composer install on fresh clones while locked to PHPUnit 10.5.45 - Add 'testing' to .gitignore (created by local CI database tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fresh clones of the repository fail on
composer installwith:This is because Composer 2.7+ blocks packages with known security advisories by default.
Why we're locked to PHPUnit 10.5.45 in v0.3
In PHPUnit 10.5.46, the
runTest()method was changed fromprotectedtoprivate:Hypervel's
RunTestsInCoroutinetrait overrides this method to intercept test execution and wrap it in a Swoole coroutine:This trick allows the trait to:
runTestsInCoroutinerunTestsInCoroutine()which wraps the actual test in a coroutine viarun()When
runTest()became private, this stops working (can't override a private method). Which breaks coroutine-based testing entirely.The Security Advisory (CVE-2026-24765)
The advisory (GHSA-vvj3-c3rp-c85p) describes an unsafe deserialization vulnerability in PHPUnit's PHPT test runner code coverage handling.
Why this doesn't affect Hypervel:
cleanupForCoverage()which deserializes.coveragefiles during PHPT testsRisk assessment: Effectively zero for this project. We're ignoring the advisory because Composer blocks it by default, not because we're accepting any actual risk.
The Fix
Adding
PKSA-z3gr-8qht-p93vto the audit ignore list allows:composer installto work on fresh clonesRunTestsInCoroutineResolution in 0.4
This will be fully resolved in Hypervel 0.4, which will use PHPUnit 13. PHPUnit 13:
runTest()Other Changes
Added
testingto.gitignore: Running the CI database integration tests locally creates atestingfile in the repository root. This is now ignored to keep the working tree clean.