Skip to content

Bind arrays correctly in PG updates #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suddendust merged 2 commits into from
May 14, 2026
+20 −3
Merged

Bind arrays correctly in PG updates #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
682035e
Bind arrays correctly in PG updates
suddendust May 14, 2026
89fec55
Merge branch 'main' into pg_bind_arrays_correctly
suddendust May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...tore/src/main/java/org/hypertrace/core/documentstore/postgres/FlatPostgresCollection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,9 +1122,7 @@ private void executeUpdate(
for (Object param : params) {
ps.setObject(idx++, param);
}
for (Object param : filterParams.getObjectParams().values()) {
ps.setObject(idx++, param);
}
filterParams.bindTo(connection, ps, idx);
int rowsUpdated = ps.executeUpdate();
LOGGER.debug("Rows updated: {}", rowsUpdated);
} catch (SQLException e) {
Expand Down
19 changes: 19 additions & 0 deletions document-store/src/main/java/org/hypertrace/core/documentstore/postgres/Params.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
package org.hypertrace.core.documentstore.postgres;

import java.sql.Array;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.util.HashMap;
import java.util.Map;
import lombok.Getter;
Expand All @@ -26,6 +30,21 @@ public Map<Integer, Object> getObjectParams() {
return objectParams;
}

public int bindTo(Connection connection, PreparedStatement ps, int startIndex)
throws SQLException {
int idx = startIndex;
for (Object value : objectParams.values()) {
if (value instanceof ArrayParam) {
ArrayParam arrayParam = (ArrayParam) value;
Array sqlArray = connection.createArrayOf(arrayParam.getSqlType(), arrayParam.getValues());
ps.setArray(idx++, sqlArray);
} else {
ps.setObject(idx++, value);
}
}
return idx;
}

public static Builder newBuilder() {
return new Builder();
}
Expand Down
Loading