fix: add PNG icon so vscode-k9 is publishable (#1)#8
Merged
Conversation
package.json declares "icon": "icons/k9-icon.png" but only k9-icon.svg existed. The VS Code Marketplace rejects SVG icons, so `vsce package` would fail outright — a hard publish blocker. Add a 128x128 RGBA PNG rendered faithfully from k9-icon.svg (same diagonal #4ad97a->#1a6a2e gradient, 16px rounded corners, white "K9" wordmark + faint accents), matching the format vscode-a2ml already ships (128x128 RGBA). icons/k9-icon.svg is retained as the source. This removes the only packaging blocker; publishing is now a single `vsce publish` once the Azure DevOps PAT is available (see issue). Refs #1 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1 (publish prep — removes the hard blocker)
package.jsondeclares"icon": "icons/k9-icon.png"but onlyk9-icon.svgexisted. The VS Code Marketplace rejects SVG icons, sovsce packagefails outright — publishing was impossible regardless of the PAT.This adds a faithful 128×128 RGBA PNG rendered from
k9-icon.svg(same gradient/corners/wordmark), matching the formatvscode-a2mlalready ships. The SVG is kept as source.After this merges,
vscode-k9is one step from done:vsce publishonce the Azure DevOps PAT exists. See the readiness-audit comment on #1.🤖 Generated with Claude Code