feat(logging): tracing diagnostics with --log-format/--log-level (#51)#110
Merged
Conversation
Add tracing + tracing-subscriber. Global --log-format=pretty|json and --log-level flags (precedence --log-level > RUST_LOG > info). The subscriber writes to stderr so the stdout data contract is never contaminated: JSON reports, the version string, the octad table, and the status/gc/validate report bodies stay on stdout verbatim. Only genuine diagnostics (schema parsing, file-write progress, "checking drift", "created manifest") become tracing events. JSON log schema documented in docs/logging.adoc + docs/logging.schema.json. New acceptance suite tests/logging_test.rs (6 tests): stdout purity, JSON-line schema validity, level filtering, RUST_LOG precedence. Closes #51. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
🔍 Hypatia Security ScanFindings: 21 issues detected
View findings[
{
"reason": "Required file missing",
"type": "missing",
"file": "SECURITY.md",
"action": "create",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Issue in quality.yml",
"type": "missing_workflow",
"file": "quality.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in security-policy.yml",
"type": "missing_workflow",
"file": "security-policy.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Action actions/checkout@v4 needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action Swatinem/rust-cache@v2 needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action actions/checkout@v4 needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action dtolnay/rust-toolchain@master needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Action Swatinem/rust-cache@v2 needs attention",
"type": "unpinned_action",
"file": "rust-ci.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Required file missing (condition: public_repo)",
"type": "missing_requirement",
"file": "SECURITY.md",
"action": "create",
"rule_module": "cicd_rules",
"severity": "high"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #51 (V-L3-I1) — replace
println!withtracing; add--log-format=json|pretty+--log-level;RUST_LOGfallback.What changed
tracing+tracing-subscriber(env-filter, json) deps.--log-format=pretty|jsonand--log-level(precedence--log-level>RUST_LOG>info), accepted before or after the subcommand.status/gc/validate/doctor/version --json), the human-readablestatus/gc/validatebodies, theoctadtable, and theversionstring remain on stdout verbatim. Only genuine diagnostics (schema parse, file-write progress, "checking drift", "created manifest") becametracingevents.docs/logging.adoc+ machine-readabledocs/logging.schema.json.Acceptance
docs/logging.schema.json; asserted in tests)RUST_LOG(with documented--log-leveloverride)Tests
New
tests/logging_test.rs(6, all green): stdout-purity forversion --jsonandoctad, JSON-line schema validity,--log-levelfiltering,--log-leveloverridingRUST_LOG, default-levelinfo.Full suite: 107 lib + 9 integration + 6 new logging = green. The single red is the pre-existing failing-by-design
provenance_fork_testintroduced by #104 and fixed by the open PR #109 (vsm#31) — it is onmain, untouched by this branch, and unrelated to logging.🤖 Generated with Claude Code