docs(adr): ESC-04 — ADR-017 ReScript block-module disposition (one module per file)#271
Merged
Merged
Conversation
#229) AffineScript is strictly one-module-per-file (ADR-011 file=module; grammar parser.mly:130-134 — `module A { }` parse-errors). #229 ports carry ReScript block modules; single-per-file is mechanical (canonical map), multi-block-per-file had no clean target (ESC-04 #262). ADR-017 (accepted): one module per file — split, do not nest. Each `module X { body }` -> its own X.affine with a `module X;` header; N block-modules -> N files. Grammar NOT extended (ADR-011/ADR-012). No compiler change — settles the porting doctrine + #229 canonical-map structural rule. The split-file Resolve.UndefinedModule is cross-module graph coherence (INT-02), tracked in RESCRIPT-ELIMINATION Tier-4, NOT conflated here. ADR-017 is sequential between ADR-016 (effect-threaded async-boundary, #234/#270) and ADR-018 (no-raw-escape, #245/#272); inserted in order in SETTLED-DECISIONS + META.a2ml + RESCRIPT-ELIMINATION ESC-04 row. Reconstructed cleanly on current main (the original branch's ADR-016 ->017 renumber history is collapsed to one in-order commit; supersedes the prior #271 head). Docs-only; gate unaffected. Refs #262 #229. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
a55e99b to
084886e
Compare
🔍 Hypatia Security ScanFindings: 47 issues detected
View findings[
{
"reason": "Stray AI.a2ml in root -- use 0-AI-MANIFEST.a2ml only",
"type": "banned",
"file": "AI.a2ml",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Superseded by 0-AI-MANIFEST.a2ml",
"type": "banned",
"file": "AI.djot",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Issue in quality.yml",
"type": "missing_workflow",
"file": "quality.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in security-policy.yml",
"type": "missing_workflow",
"file": "security-policy.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Action actions/checkout@v4 needs attention",
"type": "unpinned_action",
"file": "publish-jsr.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action denoland/setup-deno@v2 needs attention",
"type": "unpinned_action",
"file": "publish-jsr.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/example/smoke_driver.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/cli.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/mod.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-016 settles ESC-04 #262: AffineScript is one-module-per-file (ADR-011 file=module; grammar has only
module Path;header). Doctrine: split, do not nest — each ReScriptmodule X { body }becomes its own X.affine with amodule X;header; multi-block files split into N. Grammar NOT extended (ADR-011/ADR-012 discipline). No compiler change; settles porting doctrine + #229 canonical-map rule. SETTLED-DECISIONS + META.a2ml ADR-016 + RESCRIPT-ELIMINATION cross-linked. The split-file Resolve.UndefinedModule is INT-02 (Tier-4), not conflated. Refs #262 #229 (not Closes — per-repo split + INT-02 remain).🤖 Generated with Claude Code