feat(effects): thread parametric Throws[E] type argument (Refs #59)#204
Merged
Conversation
STAGE-B cleanup. lower_effect_expr dropped EffCon type args, so `Throws[MyErr]` collapsed to bare `Throws` — the type parameter the #59 v1 list calls for (`Throws[E]`) was invisible. Now the args are mangled into the effect singleton: `Throws[MyErr]` -> ESingleton "Throws[MyErr]", distinct from `Throws[Other]` and bare `Throws` under the string-equality unification of `eff`. Chosen over growing the `eff` ADT with a parametric variant (which would ripple across every effect operation in effect.ml/unify.ml — disproportionate for this cleanup). The base name is still validated via the v1 registry (`Bogus[E]` is still rejected — verified). Scope: this is effect *tracking* only. AffineScript does not currently *enforce* effect-annotation subsumption at call sites (verified: even `IO` body vs `Mut` decl passes today) — strict effect checking / handler semantics remain the separately-deferred work (migration-stance doc; #59 "tracking alone gives most of the value"). This PR makes the tracked form carry `E`; it does not add enforcement. dune build clean; dune test --force 253/253, zero regression. Refs #59 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 18, 2026
hyperpolymath
added a commit
that referenced
this pull request
May 18, 2026
#209) The #207 squash-merge landed only the code commit; the docs commit (235e161) never reached main, leaving SPEC.adoc §3.4 still showing the retired Exn[Error] and lib/effect.ml still claiming Throws[E] is 'not yet threaded' — both now stale/incorrect on main. Re-landing them: - SPEC.adoc §3.4: Exn[Error] → Throws[E]; new 'Effect inference (tracking-only v1)' subsection (catch-less try/? ⇒ Partial; declared rows enforced inferred⊆declared; undeclared permissive); 'Partial by Default' disambiguated from the Partial effect. - lib/effect.ml: corrected the doc-drift comment (#204 threads Throws[E] via name-mangling in Typecheck.lower_effect_expr). Pure docs/comment; gate unchanged. Refs #59 (closed — lineage only, do not reopen). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔍 Hypatia Security ScanFindings: 44 issues detected
View findings[
{
"reason": "Stray AI.a2ml in root -- use 0-AI-MANIFEST.a2ml only",
"type": "banned",
"file": "AI.a2ml",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Superseded by 0-AI-MANIFEST.a2ml",
"type": "banned",
"file": "AI.djot",
"action": "delete",
"rule_module": "root_hygiene",
"severity": "high"
},
{
"reason": "Issue in quality.yml",
"type": "missing_workflow",
"file": "quality.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in security-policy.yml",
"type": "missing_workflow",
"file": "security-policy.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/example/smoke_driver.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/cli.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/mod.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/compile.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
},
{
"reason": "TypeScript file detected -- banned language",
"type": "banned_language_file",
"file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/runner.ts",
"action": "flag",
"rule_module": "cicd_rules",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STAGE-B cleanup — parametric
Throws[E]lower_effect_exprdroppedEffContype args, soThrows[MyErr]collapsed to bareThrows— the type parameter the #59 v1 list specifies (Throws[E]) was invisible in the effect representation.Change
EffConargs are now mangled into the effect singleton:Throws[MyErr]→ESingleton "Throws[MyErr]", distinct fromThrows[Other]and bareThrowsundereff's string-equality unification.Chosen over adding a parametric variant to the
effADT — that would ripple across every effect operation ineffect.ml/unify.ml, disproportionate for a cleanup. The base name is still validated through the v1 registry.Scope (honest)
This is effect tracking only. AffineScript does not currently enforce effect-annotation subsumption at call sites — verified: even
IObody vsMutdecl, or pure body vsIOdecl, pass today. Strict effect checking / handler semantics are the separately-deferred work (migration-stance guide; #59: "tracking alone gives most of the value"). This PR makes the tracked form carryE; it deliberately does not add enforcement.Verification
dune buildclean;dune test --force253/253, zero regression.Bogus[Int]still rejected → the parametric path runs and base-name validation works.Throws[Int]lowers distinctly fromThrows[String]/ bareThrowsby construction.Refs #59