feat(vscode): function-value callback ABI — registerCommand/onDidSave/withProgress (Refs #199)

[hyperpolymath]

#199 PR-5a — function-value callback ABI

Owner chose the function-value ABI. Replaces the brittle wasm-table-index handler: Int convention with real function values.

ABI shape decision (no compiler change)

handler: fn(Unit) -> R, not fn() -> R. AffineScript deliberately types a zero-param function as its bare return type (typecheck.ml:752), so fn() -> Int collapses to Int and won't unify. The explicit Unit param is the honest realisation and needs zero compiler change (verified). Full rationale in #199.

Change

• stdlib/Vscode.affine: registerCommand / onDidSaveTextDocument / withProgressNotification handler params Int → fn(Unit) -> R. Also removes the duplicate extern type Thenable; introduced in feat(stdlib): async-extern binding surface — Thenable + withProgress/sendRequest (Refs #103) #198 (line 43 already declares it) — resolved at source.
• examples/vscode_extension_minimal.affine + editors/vscode/src/extension.affine: call sites migrated from numbered table indices to fn(u: Unit) => handler_x() lambdas. Behaviour-preserving — the named handler functions are unchanged.

Verification

• stdlib / example / editors extension all typecheck.
• dune test --force 253/253. (A transient Examples-parse failure was my own _u typo — leading-underscore identifiers parse-error as params; a separate minor lexer observation, used u.)
• Deno-ESM emits registerCommand("…", ((u) => handler_0())) — a real JS arrow passed directly. So the Deno fn-value extern path (PR-5b) needs no codegen change and is proven here.

Follow-ups

• PR-5c: wasm mod.js marshalling (wrapHandler currently expects an Int table index; now receives a function value).
• PR-5d: rsr-certifier pilot restore (now unblocked — withProgress takes a function).

Refs #199

[github-actions]

🔍 Hypatia Security Scan

Findings: 44 issues detected

Severity	Count
🔴 Critical	12
🟠 High	21
🟡 Medium	11

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "Stray AI.a2ml in root -- use 0-AI-MANIFEST.a2ml only",
    "type": "banned",
    "file": "AI.a2ml",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "high"
  },
  {
    "reason": "Superseded by 0-AI-MANIFEST.a2ml",
    "type": "banned",
    "file": "AI.djot",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "high"
  },
  {
    "reason": "Issue in quality.yml",
    "type": "missing_workflow",
    "file": "quality.yml",
    "action": "create",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in security-policy.yml",
    "type": "missing_workflow",
    "file": "security-policy.yml",
    "action": "create",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
    "type": "unpinned_action",
    "file": "governance.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/example/smoke_driver.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/cli.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/compile.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/lib/runner.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence