refactor: switch CLI argument parsing to clap#27
Merged
ppenna merged 1 commit intohyperlight-dev:mainfrom Feb 5, 2026
Merged
Conversation
Contributor
Author
|
should retrigger ci once #26 is in |
There was a problem hiding this comment.
Pull request overview
This PR refactors the CLI argument parsing from manual implementation to using the clap derive macros, improving maintainability and user experience.
Changes:
- Replaces manual argument parsing with clap's derive API
- Converts
--setup-registryand--clear-registryflags to subcommands - Changes script path from a searched argument to a proper positional parameter
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Adds clap dependency with derive feature |
| Cargo.lock | Adds clap and its dependencies to the lock file |
| src/bin/hyperlight-nanvix.rs | Implements clap-based CLI with Cli struct, Commands enum, and updated main function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0c2658b to
ecb2f1f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ppenna
approved these changes
Feb 5, 2026
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
ecb2f1f to
0027169
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces manual command-line argument parsing with clap derive macros.
Changes
Clistruct with clap attributes for argument parsing--setup-registryand--clear-registryflags to subcommands (setup-registry,clear-registry)--verboseas a flagUsage