feat(tonic-build): rpit / async_trait configuration#2467
Open
tomDev5 wants to merge 6 commits intohyperium:masterfrom
Open
feat(tonic-build): rpit / async_trait configuration#2467tomDev5 wants to merge 6 commits intohyperium:masterfrom
tomDev5 wants to merge 6 commits intohyperium:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#2283
Solution
Essentially used the modifications to
server.rsfrom the original PR, but under a config flag (the default is still async_trait).Tests will be added shortly, creating this to get some feedback on the code (I currently plan on asserting that the generated content from some proto file equals exactly what I expect, but other ideas are welcome).