Open
Conversation
tottoto
force-pushed
the
make-tracing-optional
branch
2 times, most recently
from
5bc0186 to
14d29d6
Compare
tottoto
force-pushed
the
make-tracing-optional
branch
from
14d29d6 to
c6cbce1
Compare
tottoto
force-pushed
the
make-tracing-optional
branch
from
c6cbce1 to
78c6ece
Compare
tottoto
force-pushed
the
make-tracing-optional
branch
3 times, most recently
from
2458c04 to
58a916c
Compare
tottoto
force-pushed
the
make-tracing-optional
branch
2 times, most recently
from
d76ae18 to
c8a2b13
Compare
|
is there any chance of approving this? |
Member
|
It will be, it's just a breaking change. |
|
Waiting for this PR to be merged. If anyone is annoyed by h2 (or any other crate) emitting tracing logs but actually useless to them, a temporary workaround is to set the tracing feature "max_level_off," which would prevent the generation of the event log code, potentially improving runtime performance and reducing the binary size. [dependencies]
# your dependencies here
tracing = { version = "*", default-features = false, features = ["max_level_off", "release_max_level_off"] } |
|
@seanmonstar is there anything that external contributors can do to help move this forward? Does it makes sense to make it an on-by-default feature to avoid the backwards compatibility issues? |
tottoto
force-pushed
the
make-tracing-optional
branch
from
c8a2b13 to
4e1e2d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #713.