Skip to content

chore: Remove the 'saved searches and dashboards have moved' callout#2299

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
drew/remove-search-dashboard-callout
May 19, 2026
Merged

chore: Remove the 'saved searches and dashboards have moved' callout#2299
kodiakhq[bot] merged 2 commits into
mainfrom
drew/remove-search-dashboard-callout

Conversation

@pulpdrew
Copy link
Copy Markdown
Contributor

@pulpdrew pulpdrew commented May 18, 2026

Summary

This PR removes the 'saved searches and dashboards have moved' message, since its been around for long enough that users have probably found their dashboards and searches.

Screenshots or video

before

Screenshot 2026-05-18 at 3 32 21 PM

after

Screenshot 2026-05-18 at 3 32 32 PM

Closes HDX-3827

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment May 19, 2026 2:02pm

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 14
  • Branch: drew/remove-search-dashboard-callout
  • Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

<!-- claude-code-review -->

PR Review

✅ No critical issues found.

Clean removal of a deprecated UX callout. Imports (Anchor, Link) remain in use elsewhere in the file, changeset is included, and no other references to the removed text exist.

@github-actions
Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

The diff removes a stale informational callout (14 JSX lines) from AppNav.tsx and adds a corresponding changeset. The removed block is purely presentational — no event handlers, state, effects, or conditional logic depend on it. Anchor and Link imports remain in use elsewhere in the same file (lines 409, 449), so no dead imports are introduced. No tests, stories, or other code reference the removed copy. Nothing further to flag.


Reviewers (4): correctness, testing, maintainability, project-standards

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

E2E Test Results

All tests passed • 179 passed • 3 skipped • 1236s

Status Count
✅ Passed 179
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew requested review from a team and wrn14897 and removed request for a team May 19, 2026 12:35
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

🦋 Changeset detected

Latest commit: e90833c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kodiakhq kodiakhq Bot merged commit 3feaa01 into main May 19, 2026
18 of 19 checks passed
@kodiakhq kodiakhq Bot deleted the drew/remove-search-dashboard-callout branch May 19, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants