feat: always-on attribute distribution mode#1855
Conversation
Show attribute value distribution charts immediately when viewing Event Deltas, without requiring a heatmap selection first. Users see attribute distributions right away, then can select an area to enable comparison mode (selection vs background). Changes: - DBDeltaChart: Accept nullable xMin/xMax/yMin/yMax props; gate outlier/inlier queries with enabled:hasSelection; add allSpansData query when no selection; add legend UI showing mode - PropertyComparisonChart: Accept hasSelection prop; show blue bars (ALL_SPANS_COLOR) in distribution mode, hide inlier bar - DBSearchHeatmapChart: Always render DBDeltaChart (remove conditional and placeholder text) - deltaChartUtils: Add ALL_SPANS_COLOR constant Closes #1824 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 971950f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @alex-fedotyev's task in 30s —— View job PR Review✅ No critical issues found. The implementation is clean and well-structured. A few minor observations:
|
E2E Test Results✅ All tests passed • 87 passed • 3 skipped • 907s
Tests ran across 4 shards in parallel. |
|
Claude finished @alex-fedotyev's task in 26s —— View job PR Review✅ No critical issues found. The implementation is clean. A couple of minor observations:
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Two fixes from code review: 1. computeComparisonScore empty-group fallback: when one group has no data, normalize the present group's values to percentages [0,100] instead of using raw counts. This prevents single-value fields with high raw counts from inflating their score relative to multi-value fields. Fixes scale inconsistency with distribution mode in #1855. 2. Wire semanticBoost into DBDeltaChart sort as a tiebreaker (0.1 weight, only when baseScore > 0). Previously exported and tested but never called. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code Review✅ No critical issues found. Clean implementation of always-on distribution mode.
Overall: well-structured change with clean separation of concerns. The |
Summary
Changes
ALL_SPANS_COLORconstant (Mantine blue-6 CSS variable)xMin/xMax/yMin/yMaxprops; derivehasSelectionboolean; gate outlier/inlier queries withenabled: hasSelection; addallSpansDataquery for distribution mode; add legend UI showing current mode; passhasSelectiontoPropertyComparisonCharthasSelectionprop (defaulttrue); show single blue bar labeled "All spans" in distribution mode; hide inlier (background) bar when no selectionDBDeltaChart(remove null-check conditional and placeholder text); remove unusedCenter/TextimportsTest plan
Closes #1824
🤖 Generated with Claude Code