Skip to content

Drew/sql chart templating#1853

Draft
pulpdrew wants to merge 4 commits intodrew/raw-sql-chart-configfrom
drew/sql-chart-templating
Draft

Drew/sql chart templating#1853
pulpdrew wants to merge 4 commits intodrew/raw-sql-chart-configfrom
drew/sql-chart-templating

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Mar 5, 2026

Summary

Screenshots or video

Before After

How to test locally or on Vercel

References

  • Linear Issue:
  • Related PRs:

@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 5, 2026 2:51pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: 6b28b88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Claude finished @pulpdrew's task in 1m 14s —— View job


PR Review

✅ Overall the code is well-structured and follows existing patterns. A few minor items worth noting:

  • ⚠️ AvailableParameters renders for non-Table display types with an empty list (RawSqlChartEditor.tsx:166) — For display types where QUERY_PARAMS_BY_DISPLAY_TYPE[displayType] is empty, the "Query parameters" collapsible panel still shows but expands to an empty list with a confusing example. Consider hiding the section entirely when availableParams.length === 0. Fix this →

  • ⚠️ undefined param values passed to ClickHouse (rawSqlParams.ts:54-56) — When dateRange is absent, startDateMilliseconds and endDateMilliseconds are undefined in the params map. If ClickHouse receives undefined for a referenced param, it may error. Consider filtering out undefined values from the params object (e.g. Object.fromEntries(queryParams.map(...).filter(([, v]) => v !== undefined))). Fix this →

  • 💡 numericRowSortingFn both-null case (DBTable/sorting.ts:15-16) — When both aValue and bValue are null/NaN, the function returns 1 (a is "greater"), which is inconsistent (should return 0). Doesn't affect sort correctness for typical use but worth noting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant