Skip to content

chore: add playwright agents for cursor and claude#1847

Merged
kodiakhq[bot] merged 3 commits intomainfrom
tom/playwright-agents
Mar 5, 2026
Merged

chore: add playwright agents for cursor and claude#1847
kodiakhq[bot] merged 3 commits intomainfrom
tom/playwright-agents

Conversation

@teeohhem
Copy link
Contributor

@teeohhem teeohhem commented Mar 4, 2026

  • Adds playwright agents for test creation with playwright mcp.
  • Enhances our playwright skill to make use of these
  • Updates contribution guide/readmes

@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2026

⚠️ No Changeset found

Latest commit: a4def74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 5, 2026 3:15pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Claude finished @teeohhem's task in 22s —— View job


PR Review

✅ No critical issues found.

This is a tooling/docs-only PR (no production code changes). A few minor observations:

  • .mcp.json and .cursor/mcp.json are identical files — consider a symlink or note in docs to keep them in sync if they diverge
  • .cursor/rules/old-rules.mdc name suggests it may be stale/temporary — worth a rename or cleanup before merge
  • The .gitignore change adds seed.spec.ts and specs/ as global ignores — these are quite generic patterns that could unintentionally mask legitimate files in other parts of the repo. Consider scoping them (e.g., packages/app/tests/e2e/seed.spec.ts)

None of these are blockers.

Also enhances playwright skill to make use of these
@teeohhem teeohhem force-pushed the tom/playwright-agents branch from a67ca11 to dfe5409 Compare March 4, 2026 20:25
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Claude finished @teeohhem's task in 28s —— View job


PR Review

✅ No critical issues found.

A few minor observations worth considering:

  • ⚠️ .gitignore adds seed.spec.ts and specs/ as global patterns (lines 9–10) — these could unintentionally hide legitimate files elsewhere in the repo. Consider scoping them: packages/app/tests/e2e/seed.spec.ts and packages/app/tests/e2e/specs/. Fix this →

  • ⚠️ .mcp.json and .cursor/mcp.json are identical files — if they diverge, it'll be a silent sync issue. Consider a note in docs to keep them in sync, or use a symlink.

  • ℹ️ The generator agent example (.claude/agents/playwright-test-generator.md line 86) has a minor syntax error in the example code: async { page } should be async ({ page }).

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

E2E Test Results

All tests passed • 87 passed • 3 skipped • 951s

Status Count
✅ Passed 87
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

pulpdrew
pulpdrew previously approved these changes Mar 5, 2026
Copy link
Contributor

@pulpdrew pulpdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the dead link. Can't wait to try it out on some real tests!

Co-authored-by: Drew Davis <drew.davis@clickhouse.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Claude finished @teeohhem's task in 27s —— View job


PR Review

✅ No critical issues found.

Two minor items worth addressing before merge:

  • ⚠️ .gitignore lines 9–10 add seed.spec.ts and specs/ as global patterns — these could unintentionally hide files elsewhere in the repo. Scope them: packages/app/tests/e2e/seed.spec.ts and packages/app/tests/e2e/specs/. Fix this →

  • ℹ️ .claude/agents/playwright-test-generator.md line 86: syntax error in example — async { page } should be async ({ page }). Fix this →

The dead link in CONTRIBUTING.md noted by @pulpdrew has already been fixed in the latest commit.

@kodiakhq kodiakhq bot merged commit 46daa63 into main Mar 5, 2026
13 of 14 checks passed
@kodiakhq kodiakhq bot deleted the tom/playwright-agents branch March 5, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants