Skip to content

feat: highlight logs green in trace waterfall#1819

Open
karl-power wants to merge 3 commits intomainfrom
karl/highlight-logs-in-trace-view
Open

feat: highlight logs green in trace waterfall#1819
karl-power wants to merge 3 commits intomainfrom
karl/highlight-logs-in-trace-view

Conversation

@karl-power
Copy link
Contributor

@karl-power karl-power commented Feb 27, 2026 •
edited
Loading

Closes HDX-3526

Changes

  • Colors logs events in the trace waterfall view green.
  • Adds a new greenHighlight color that applies the same lightening transformation as the other highlight colors.
  • Makes use of the barColor util DBTraceWaterfallChart again that was being overwritten.

Screenshots

Screenshot 2026-02-27 at 13 43 26 Screenshot 2026-02-27 at 13 42 45

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 14d0ca6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 27, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 6, 2026 4:13pm
hyperdx-v2-oss-app Ready Ready Preview, Comment Mar 6, 2026 4:13pm

Request Review

@karl-power karl-power requested review from a team, bot-hyperdx and dhable and removed request for a team and bot-hyperdx February 27, 2026 13:42
@karl-power karl-power force-pushed the karl/timeline-components-refactor branch from cf27bcd to 7343f89 Compare February 27, 2026 14:23
@karl-power karl-power force-pushed the karl/highlight-logs-in-trace-view branch from aa10eb6 to fc3bd26 Compare February 27, 2026 14:24
@karl-power karl-power force-pushed the karl/timeline-components-refactor branch from 7343f89 to bc39179 Compare March 2, 2026 12:39
@karl-power karl-power force-pushed the karl/highlight-logs-in-trace-view branch from fc3bd26 to a4ab8d4 Compare March 2, 2026 12:40
@karl-power karl-power force-pushed the karl/timeline-components-refactor branch from bc39179 to 131fc4c Compare March 3, 2026 09:38
@karl-power karl-power force-pushed the karl/highlight-logs-in-trace-view branch from a4ab8d4 to d194e51 Compare March 3, 2026 09:39
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026 •
edited
Loading

Claude finished @karl-power's task in 38s —— View job

Code Review

  • ⚠️ Missing dark theme token → --color-chart-success-highlight is defined only in the light theme section of _tokens.scss (line 107) but not in the dark theme block (lines 212-214). Add it alongside --color-chart-error-highlight and --color-chart-warning-highlight in the dark theme. Fix this →

Otherwise looks clean — the refactor to move color/backgroundColor into the event data model (rather than eventStyles callback) is a nice simplification, and the log-type check in barColor follows the existing error/warn pattern correctly.

@karl-power karl-power force-pushed the karl/highlight-logs-in-trace-view branch from d194e51 to 18dc567 Compare March 3, 2026 09:55
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026 •
edited
Loading

Claude finished @karl-power's task in 1m 1s —— View job

Code Review

  • Gather context and read changed files
  • Provide review feedback
  • ⚠️ src/hooks/useDrag.ts is dead code — the file is added but TimelineChart.tsx:6 still imports useDrag from ../../utils. Either migrate TimelineChart to use the new hook (and remove the one from utils.ts), or remove the new file. Fix this →

Otherwise looks good — the previous dark theme token issue (--color-chart-success-highlight missing from dark mode mixin) is now fixed, and the log green-highlight feature correctly follows the existing error/warn pattern in barColor.

@karl-power karl-power force-pushed the karl/highlight-logs-in-trace-view branch from 18dc567 to ed9a1ec Compare March 3, 2026 12:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026 •
edited
Loading

Claude finished @karl-power's task in 54s —— View job

Code Review

  • Gather context and read changed files
  • Provide review feedback

✅ No critical issues found.

The previous dark theme token issue (--color-chart-success-highlight missing from dark mode) is now fixed in both hyperdx/_tokens.scss and clickstack/_tokens.scss. The refactor to move color/backgroundColor into the event data model (removing the eventStyles callback) is a clean simplification, and the log-type green highlight in barColor follows the existing error/warn pattern correctly.

@karl-power karl-power force-pushed the karl/timeline-components-refactor branch from 131fc4c to 077a0f4 Compare March 4, 2026 10:03
@karl-power karl-power force-pushed the karl/highlight-logs-in-trace-view branch from ed9a1ec to 966a550 Compare March 4, 2026 10:03
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026 •
edited
Loading

Claude finished @karl-power's task in 1m 34s —— View job

Code Review

  • Gather context and read changed files
  • Provide review feedback

✅ No critical issues found.

The dark theme token concern (--color-chart-success-highlight missing from dark mode) is confirmed fixed in both hyperdx/_tokens.scss and clickstack/_tokens.scss. The useDrag.ts dead code mentioned in a prior review is no longer present. The refactor from eventStyles callback to color/backgroundColor fields on TTimelineEvent is a clean improvement, and the SourceKind.Log green highlight in barColor correctly follows the existing error/warn pattern.

teeohhem
teeohhem previously approved these changes Mar 4, 2026
View reviewed changes
@karl-power karl-power changed the base branch from karl/timeline-components-refactor to main March 5, 2026 11:54
@karl-power karl-power dismissed teeohhem’s stale review March 5, 2026 11:54

The base branch was changed.

@kodiakhq kodiakhq bot removed the automerge label Mar 5, 2026
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 5, 2026

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@karl-power karl-power force-pushed the karl/highlight-logs-in-trace-view branch from 966a550 to bf5202c Compare March 5, 2026 11:55
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026 •
edited
Loading

Claude finished @karl-power's task in 14s —— View job

  • Gather context and read changed files
  • Provide review feedback

✅ No critical issues found.

All previously flagged issues have been resolved:

  • Dark theme token (--color-chart-success-highlight) is now present in both hyperdx/_tokens.scss and clickstack/_tokens.scss
  • Dead code (useDrag.ts) is no longer present
  • The SourceKind.Log green highlight in barColor correctly follows the existing error/warn pattern
  • The refactor from eventStyles callback to color/backgroundColor fields on TTimelineEvent is a clean improvement

Note: There is an active merge conflict on this PR (flagged by Kodiak). You'll need to resolve that before merging.

@karl-power karl-power requested a review from teeohhem March 5, 2026 11:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026 •
edited
Loading

E2E Test Results

✅ All tests passed • 87 passed • 3 skipped • 935s

Status Count
✅ Passed 87
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

cursor[bot]
cursor bot reviewed Mar 6, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

✅ No critical issues found.

Open in Web View Automation 

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

cursor[bot]
cursor bot reviewed Mar 6, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No critical issues found.

Open in Web View Automation 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@dhable dhable Awaiting requested review from dhable dhable was automatically assigned from hyperdxio/hyperdx-team

@teeohhem teeohhem Awaiting requested review from teeohhem

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karl-power @teeohhem