SDS call routing #60
Merged
SDS call routing #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PDS/SDS) When using OAuth to access organization repositories on SDS via repo.repo(orgDid), operations were incorrectly routing to the user's PDS instead of the SDS server. Root cause: Agent was created from OAuth session but only had api.xrpc.uri configured. Without setting agent.service, it continued using session's default PDS URL. Solution: Set both agent.service and agent.api.xrpc.uri in Repository constructor to ensure all operations route to the specified server URL. Affected operations: - HypercertOperationsImpl: list(), listCollections(), get(), create() - RecordOperationsImpl: all CRUD operations - ProfileOperationsImpl: get(), update() - BlobOperationsImpl: upload(), get() Also added comprehensive PDS/SDS orchestration documentation to README covering server types, routing mechanics, and common usage patterns. Fixes: Repository operations on organization repos routing to user's PDS Location: packages/sdk-core/src/repository/Repository.ts:188
… type safety - Remove non-existent agent.service and agent.api.xrpc.uri property assignments that were causing TypeScript errors (TS2339) - Agent service URL is properly configured through Session's fetch handler - Replace 'any' types in test files with proper types (Partial<Agent>, Partial<Session>) - Use createMockSession() helper for consistent test mocking - All builds, lints, and tests now pass without warnings Fixes: TypeScript compilation errors in Repository.ts:189-190 Fixes: ESLint @typescript-eslint/no-explicit-any warnings in test files
Add ConfigurableAgent class that extends Agent to support routing requests to configurable service URLs, enabling proper PDS/SDS separation and multi-SDS support. Key features: - ConfigurableAgent wraps session's fetch handler to route to custom URL - Repository now uses ConfigurableAgent instead of standard Agent - Supports multiple SDS instances with same OAuth session - Maintains all authentication (DPoP, OAuth) from original session Architecture: - Agent's service URL is determined by FetchHandler, not modifiable properties - ConfigurableAgent creates custom FetchHandler that prepends target URL - Session's fetch handler provides authentication layer - Enables: user@PDS accessing orgA@SDS and orgB@SDS simultaneously Use cases: - Route to SDS while authenticated via PDS - Access multiple organization SDS instances - Test against different server environments - Switch between PDS and SDS operations dynamically Resolves the issue where invalid agent.service and agent.api.xrpc.uri property assignments were attempted. The proper solution is to wrap the fetch handler at Agent construction time. Related: #59, implements pattern from hypercerts-org/atproto sds-demo
Define FetchHandler type locally instead of importing from @atproto/xrpc to avoid TypeScript warning about missing type declarations during build. The type definition is simple and stable, so local definition is preferred.
🦋 Changeset detectedLatest commit: f7594f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TypeScript errors and implement ConfigurableAgent for multi-server routing
Summary
This PR fixes TypeScript compilation errors and implements proper multi-server routing using a new
ConfigurableAgentclass, enabling reliable PDS/SDS separation and multi-SDS support.Changes
🐛 Bug Fixes
agent.serviceandagent.api.xrpc.uriproperty assignments causing TS2339 errorsanytypes in test files with proper type annotations@atproto/xrpcimport✨ New Features
ConfigurableAgentclass for routing requests to configurable service URLs📝 Documentation
Architecture
ConfigurableAgentwraps the OAuth session's fetch handler to prepend the target server URL, ensuring requests route to the intended destination while maintaining full authentication (DPoP, access tokens, etc.).Use Cases