SDS record queries #58
Merged
+526
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDS API returns permissions as objects with boolean flags
({ read: true, create: true, ... }), not string arrays. This updates
the parsePermissions method to handle the correct format and prevents
TypeError when calling .includes() on objects.
- Simplify parsePermissions() to match actual SDS API response structure
- Update type annotations from string[] to CollaboratorPermissions
- Fix test mocks to use object format instead of string arrays
- Update changeset with accurate description of changes
Fixes 'TypeError: permissionArray.includes is not a function' error
when listing collaborators from organization repositories.
…ries The Agent was using the default PDS service URL from the OAuth session even when querying SDS repositories, causing 'Could not find repo' errors. This configures the Agent's XRPC URI to use the specified server URL (PDS or SDS) so queries are routed to the correct service endpoint. - Set agent.api.xrpc.uri to the serverUrl in Repository constructor - Ensures SDS repository queries reach the SDS server - Resolves 400 errors when listing hypercerts/collections from organizations - All 317 tests passing Fixes 'Could not find repo' errors when querying shared repositories.
🦋 Changeset detectedLatest commit: 3dfaf35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.