docs: add experimental software disclaimer#141
Conversation
Add prominent warning that this SDK is experimental and not for production use. Directs users to the ATProto SDK and scaffold app for production. Changes: - Add warning banner to root README.md - Add warning banner to sdk-core README.md - Add warning banner to sdk-react README.md - Add runtime console.warn on SDK instantiation
|
📝 WalkthroughWalkthroughAdded experimental-use warnings and disclaimers across project documentation and SDK initialization. Console warning messages direct users away from production use and reference alternative SDKs and resources. No functional logic changes introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/sdk-core/src/core/SDK.ts (1)
178-183: Route the experimental warning through the SDK logger first.Line 179 logs directly with
console.warn, which bypasses the configuredloggerand makes warning handling less controllable for integrators. Preferthis.logger?.warnwith a console fallback.🔧 Proposed refactor
- // Experimental software warning - console.warn( - "[`@hypercerts-org/sdk-core`] ⚠️ This SDK is experimental and should not be used in production. " + - "For production use, please use the ATProto SDK (https://github.com/bluesky-social/atproto) " + - "and the scaffold app (https://github.com/hypercerts-org/hypercerts-app).", - ); + // Experimental software warning + const EXPERIMENTAL_WARNING = + "[`@hypercerts-org/sdk-core`] ⚠️ This SDK is experimental and should not be used in production. " + + "For production use, please use the ATProto SDK (https://github.com/bluesky-social/atproto) " + + "and the scaffold app (https://github.com/hypercerts-org/hypercerts-app)."; + if (this.logger?.warn) { + this.logger.warn(EXPERIMENTAL_WARNING); + } else { + console.warn(EXPERIMENTAL_WARNING); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/sdk-core/src/core/SDK.ts` around lines 178 - 183, Replace the direct console.warn call in the experimental software warning block with the SDK's logger: call this.logger?.warn(message) and, if this.logger is undefined, fall back to console.warn(message); ensure you use the exact same warning text and locate the change in the experimental software warning section inside the SDK class (the block currently using console.warn in SDK.ts) so the message is routed through the SDK logger first.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/sdk-core/src/core/SDK.ts`:
- Around line 178-183: Replace the direct console.warn call in the experimental
software warning block with the SDK's logger: call this.logger?.warn(message)
and, if this.logger is undefined, fall back to console.warn(message); ensure you
use the exact same warning text and locate the change in the experimental
software warning section inside the SDK class (the block currently using
console.warn in SDK.ts) so the message is routed through the SDK logger first.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 21d4137e-47a2-4cf1-9d90-3a4b15c983ef
📒 Files selected for processing (4)
README.mdpackages/sdk-core/README.mdpackages/sdk-core/src/core/SDK.tspackages/sdk-react/README.md
Summary
Adds a prominent disclaimer across the SDK that this is experimental software and should not be used in production.
Changes
console.warn()on SDK instantiation so developers see the warning at runtimeDisclaimer text
Testing
pnpm build)pnpm lint)localStorage.clearissue)Summary by CodeRabbit