chore(sdk-core): enhance RichText changeset with versioning note and usage examples#136
chore(sdk-core): enhance RichText changeset with versioning note and usage examples#136
Conversation
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughA changeset update clarifies the public API documentation for rich text facet creation functions, explicitly documenting mention resolution behavior based on whether an agent is provided, with no functional changes to the implementation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR enhances the changeset documentation for the RichText utility functions by adding clarifications and usage examples. The changes improve the developer experience by providing better context about versioning, mention handling behavior, and practical code examples.
Changes:
- Adds a 0.x versioning note clarifying this is a non-breaking addition
- Corrects the description of unresolved mention handling to accurately state that the handle string is used as the DID
- Adds TypeScript usage examples demonstrating both sync and async function usage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/add-richtext-utility.md:
- Around line 19-27: The code block declares const facets twice causing a
redeclaration error; change the duplicate variable names so each call uses a
unique identifier (e.g., rename the result of createFacetsFromTextSync(...) to
facetsSync and the result of await createFacetsFromText(...) to facetsAsync) and
ensure the async example stays in an async context when using await; update
references accordingly for createFacetsFromTextSync and createFacetsFromText.
CodeRabbit flagged that both const declarations in the same block scope caused a TS/ES6 redeclaration error. Rename to facetsSync/facetsAsync.
Summary
createFacetsFromTextandcreateFacetsFromTextSyncDetails
This cherry-picks a single commit (
c175665) from thebannerbranch that improves theadd-richtext-utility.mdchangeset documentation. It is entirely unrelated to the DID validation and blob ref changes on that branch and can be merged independently.Only
.changeset/add-richtext-utility.mdis modified — no source code changes.Extracted from #123.